After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732454 - Build error: return_exposes not defined in gdkevents-win32.c due to recent cleanup work
Build error: return_exposes not defined in gdkevents-win32.c due to recent cl...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Windows
: Normal blocker
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-06-30 06:08 UTC by Wesley Chan
Modified: 2014-07-03 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Wesley Chan 2014-06-30 06:08:21 UTC 
I've encounter an error building GTK+ 3.13.3 for Win32.

In the file gdk/win32/gdkevents-win32.c, line 1531:
-----------------------
  GDK_NOTE (EVENTS, g_print (" %s %s dc %p%s",
			     _gdk_win32_rect_to_string (&paintstruct.rcPaint),
			     (paintstruct.fErase ? "erase" : ""),
			     hdc,
			     (return_exposes ? " return_exposes" : "")));
-----------------------
return_exposes in the last line is not defined.

This is due to a recent commit, Remove dead code. Here.
https://git.gnome.org/browse/gtk+/commit/gdk/win32/gdkevents-win32.c?id=4d8cd2f7cf143fbee57c5c7e6aed76755e792bb5

St. Pierre removed the argument, but he didn't completely remove the variable.

Please kindly notice that. Thank you!

One more question. Being a quick solution, is removing that variable completely appropriate, and of what St. Pierre was trying to do?
Thanks again.