After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732438 - build: don't default to -g -fexceptions
build: don't default to -g -fexceptions
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-29 17:35 UTC by Michael Catanzaro
Modified: 2014-06-30 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: don't default to -g -fexceptions (1.01 KB, patch)
2014-06-29 17:35 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-06-29 17:35:40 UTC
See patch
Comment 1 Michael Catanzaro 2014-06-29 17:35:42 UTC
Created attachment 279549 [details] [review]
build: don't default to -g -fexceptions

-g by default is very unconventional, and I have no clue why C++
exception support would be wanted here?
Comment 2 Richard Hughes 2014-06-30 07:29:02 UTC
Review of attachment 279549 [details] [review]:

Yup, looks fine, thanks.
Comment 3 Michael Catanzaro 2014-06-30 16:49:54 UTC
Attachment 279549 [details] pushed as 5986c62 - build: don't default to -g -fexceptions