After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732437 - gpk-log: improve Application column results
gpk-log: improve Application column results
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-29 17:35 UTC by Michael Catanzaro
Modified: 2014-06-30 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gpk-log: improve Application column results (2.70 KB, patch)
2014-06-29 17:35 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-06-29 17:35:19 UTC 
Everything in the Application column of gpk-log is blank. This patch doesn't fix that, but should help a little.
Comment 1 Michael Catanzaro 2014-06-29 17:35:21 UTC 
Created attachment 279548 [details] [review]
gpk-log: improve Application column results

* Update some of the user-friendly display names
* Add GNOME Software
* Look for substrings, not exact matches. In particular, matching on
  /usr/libexec is mean since that only exists in Red Hat distros.
Comment 2 Richard Hughes 2014-06-30 07:30:52 UTC 
Review of attachment 279548 [details] [review]:

Looks fine, thanks. I'd prefer g_strstr_len but that's probably the same thing as strstr under the covers anyway.
Comment 3 Michael Catanzaro 2014-06-30 16:41:58 UTC 
Well we know the string is null-terminated, but we don't know its length, so besides setting an arbitrary max like 512 I'm not sure why we'd want g_strstr_len?
Comment 4 Michael Catanzaro 2014-06-30 16:50:02 UTC 
Attachment 279548 [details] pushed as 75d4007 - gpk-log: improve Application column results