After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732396 - Desktop file malformed when bindir is unset
Desktop file malformed when bindir is unset
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2014-06-28 18:17 UTC by Jan Alexander Steffens (heftig)
Modified: 2014-07-01 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.15 KB, patch)
2014-06-30 21:46 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2014-06-28 18:17:24 UTC 
The value for bindir is put into the desktop file without further substitution. 

If it is left at the default, it becomes a literal "Exec=${exec_prefix}/bin/seahorse", rendering the desktop file unusable.

Workaround is to set the bindir explicitly, e.g. using "--bindir=/usr/bin".
Comment 1 Stef Walter 2014-06-30 10:46:08 UTC 
Thanks for reporting this. Are you interested in providing a patch for this issue?
Comment 2 Jan Alexander Steffens (heftig) 2014-06-30 11:58:47 UTC 
Yes, I'll look into it.
Comment 3 Jan Alexander Steffens (heftig) 2014-06-30 21:46:25 UTC 
Created attachment 279637 [details] [review]
patch

This seems to work.
Comment 4 Stef Walter 2014-07-01 07:05:27 UTC 
Thanks. Merged the fix into git master, after making a few Makefile.am
tweaks so that 'make distcheck' doesn't fail.