After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732393 - build: allow forcing building the yocto base
build: allow forcing building the yocto base
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-28 16:15 UTC by Owen Taylor
Modified: 2014-06-30 14:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: allow forcing building the yocto base (1.33 KB, patch)
2014-06-28 16:16 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2014-06-28 16:15:59 UTC
There is no way currently to trigger rebuilding the base if you have
it in overrides/ - there was commented code out that caused the base
to be rebuilt if:

 A) forceComponents=["yocto"] was passed on the command line
 B) Always if it's in overrides/

B) is not tenable considering how slow a build of the base is, but
A) seems useful and harmless, so uncomment it.
Comment 1 Owen Taylor 2014-06-28 16:16:01 UTC
Created attachment 279491 [details] [review]
build: allow forcing building the yocto base
Comment 2 Colin Walters 2014-06-30 01:25:28 UTC
Review of attachment 279491 [details] [review]:

I think only A) works because B) will fail to look it up in the component list or something?  Anyways, yep.
Comment 3 Owen Taylor 2014-06-30 14:35:21 UTC
(In reply to comment #2)
> Review of attachment 279491 [details] [review]:
> 
> I think only A) works because B) will fail to look it up in the component list
> or something?  Anyways, yep.

I don't really quite understand - the base is in manifest.json as "yocto", but the code is otherwise pretty much entirely separate from the code to handle normal components - as far as I know it doesn't reference the computed lists of components to build.
Comment 4 Owen Taylor 2014-06-30 14:36:17 UTC
Attachment 279491 [details] pushed as e52a829 - build: allow forcing building the yocto base