After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732358 - Exit with a non-zero exit status when 'ostbuild make' fails
Exit with a non-zero exit status when 'ostbuild make' fails
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-27 19:24 UTC by Owen Taylor
Modified: 2014-06-29 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Exit with a non-zero exit status when 'ostbuild make' fails (4.27 KB, patch)
2014-06-27 19:24 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2014-06-27 19:24:54 UTC
Make the execute() function of builtins return true/false to indicate
success or failure, and use this so that 'ostbuild make' has the right
exit status, allowing 'ostbuild make && ...' to work properly.
Comment 1 Owen Taylor 2014-06-27 19:24:56 UTC
Created attachment 279437 [details] [review]
Exit with a non-zero exit status when 'ostbuild make' fails
Comment 2 Colin Walters 2014-06-27 22:17:53 UTC
Review of attachment 279437 [details] [review]:

Looks right, thanks!
Comment 3 Owen Taylor 2014-06-29 19:41:35 UTC
Attachment 279437 [details] pushed as 0481222 - Exit with a non-zero exit status when 'ostbuild make' fails