After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732311 - [PATCH] Gettext 0.19 fails for missing translation header data
[PATCH] Gettext 0.19 fails for missing translation header data
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: other
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME i18n team
Christian Rose
Depends on:
Blocks:
 
 
Reported: 2014-06-27 05:00 UTC by Max Mustermann
Modified: 2015-09-26 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add missing "Language:" information (85.20 KB, patch)
2014-06-27 05:00 UTC, Max Mustermann
none Details | Review

Description Max Mustermann 2014-06-27 05:00:39 UTC
Created attachment 279358 [details] [review]
Patch to add missing "Language:" information

A few days ago, after an update to GNU Gettext 0.19, 'msgfmt -c'
started failing because of missing po header info. The "Language:"
entry was missing in some po files.

The newer Gettext 0.19.1 behaves a bit more tolerant and returns
only warnings without breaking the build anymore.
However, I take these warnings seriously and fixed their causes
in the po files.
My patch adds missing "Language:" information, trailing "\n"'s and
cleans up duplicate lines. 
I discussed it on the GNOME-I18N mailing list and was told to place it here. 
Additionally to the last discussed status I corrected the language codes in 
ca@valencia.po to ca-XV and be@latin.po to be-latin.
The patch is based on version 2.24.24.
Comment 1 Piotr Drąg 2014-06-27 13:42:24 UTC
(In reply to comment #0)
> Additionally to the last discussed status I corrected the language codes in 
> ca@valencia.po to ca-XV and be@latin.po to be-latin.

Please do not modify language codes. Even if this change was correct (and it isn't), it should be done in coordination with appropriate language maintainers and across the whole GNOME.
Comment 2 Max Mustermann 2014-06-28 08:28:18 UTC
Ok, I meant it well and was a bit too fussy ;-)
I think the Catalan and Belarussian language teams should clarify the proper language codes among themselves and correct the wrong files accordingly. This is clearly beyond my possibilities. 
Here is the link to the last patch that found agreement on the GNOME-I18N mailing list: https://mail.gnome.org/archives/gnome-i18n/2014-June/bz2CAo9mLg2y4.bz2 (please don't ask me why the filename looks so garbled now; it must be something in the way attachments are stored at mail.gnome.org).
Comment 3 Piotr Drąg 2015-09-26 17:25:07 UTC
I've applied the changes manually:

https://git.gnome.org/browse/gtk+/commit/?h=gtk-2-24&id=b3ff8bbe313a59d76ae63012f407fc0037ae3989