After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732295 - Add meta_key_binding_is_reversed()
Add meta_key_binding_is_reversed()
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 731618
 
 
Reported: 2014-06-26 20:18 UTC by Christophe Fergeau
Modified: 2014-08-17 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add meta_key_binding_is_reversed() (2.45 KB, patch)
2014-06-26 20:18 UTC, Christophe Fergeau 		reviewed Details | Review
Add meta_key_binding_is_reversed() (2.46 KB, patch)
2014-07-02 16:40 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2014-06-26 20:18:18 UTC 
MetaKeyBinding can be marked as being reversed
(META_KEY_BINDING_IS_REVERSED), but MetaKeyHandlerFunc callbacks
cannot check whether this flag was set or not on the MetaKeyBinding
which triggered the callback.
Comment 1 Christophe Fergeau 2014-06-26 20:18:35 UTC 
Created attachment 279336 [details] [review]
Add meta_key_binding_is_reversed()
Comment 2 Florian Müllner 2014-06-26 21:00:50 UTC 
Review of attachment 279336 [details] [review]:

::: src/core/keybindings.c
@@ +2795,3 @@
                gpointer         dummy)
 {
+  gint backwards = meta_key_binding_is_reversed (binding);

While you're modifying this, can you change the variable to gboolean?

@@ +2807,3 @@
               gpointer         dummy)
 {
+  gint backwards = meta_key_binding_is_reversed (binding);

Dto.
Comment 3 Christophe Fergeau 2014-07-02 16:40:22 UTC 
Created attachment 279791 [details] [review]
Add meta_key_binding_is_reversed()

MetaKeyBinding can be marked as being reversed
(META_KEY_BINDING_IS_REVERSED), but MetaKeyHandlerFunc callbacks
cannot check whether this flag was set or not on the MetaKeyBinding
which triggered the callback.
Comment 4 Florian Müllner 2014-07-02 16:50:05 UTC 
Review of attachment 279791 [details] [review]:

OK
Comment 5 Christophe Fergeau 2014-08-17 17:32:26 UTC 
Attachment 279791 [details] pushed as c5c6b22 - Add meta_key_binding_is_reversed()