GNOME Bugzilla – Bug 732293
Add default binding for switch-input-source-backward
Last modified: 2014-08-17 17:29:29 UTC
Currently mutter/gnome-shell make sure switch-input-source-backward shortcut is set to <Shift> + switch-input-source shortcut, but this is being moved to gnome-control-center, which needs the default value to be set.
Created attachment 279334 [details] [review] Add default binding for switch-input-source-backward
Review of attachment 279334 [details] [review]: The commit message mentions mutter, but I can't find any mentions of that keybinding in mutter, just gnome-shell. ::: schemas/org.gnome.desktop.wm.keybindings.gschema.xml.in.in @@ +333,3 @@ </key> <key name="switch-input-source" type="as"> + <default><![CDATA[['<Super>space']]]></default> I'd prefer if the CDATA change was made separately.
Review of attachment 279334 [details] [review]: I mentioned mutter in the log because of https://git.gnome.org/browse/mutter/tree/src/core/keybindings.c#n624 switch-input-source has the META_KEY_BINDING_REVERSES flag set, so even though switch-input-source-backwards has no key binding set, one is implicitly created for the reverse action. ::: schemas/org.gnome.desktop.wm.keybindings.gschema.xml.in.in @@ +333,3 @@ </key> <key name="switch-input-source" type="as"> + <default><![CDATA[['<Super>space']]]></default> Sure, will split.
Created attachment 279473 [details] [review] Use CDATA to encode switch-input-source default binding Currently entities are being used, but CDATA is more readable and more consistent with the rest of the file.
Created attachment 279474 [details] [review] Add default binding for {switch,cycle}.*-backward bindings Currently mutter/gnome-shell make sure that the binding for a -backward action is the same binding as for the non-backward action with the <Shift> modifier added. This logic is being moved to gnome-control-center for more flexibility (the keybinding panel will suggest to set the -backward binding to <Shift>+non-backward-binding). Since mutter/gnome-shell will no longer be automatically creating these <Shift> backward keybindings, they need to be added as default values to the -backward gsettings keys.
Review of attachment 279473 [details] [review]: Looks good.
Review of attachment 279474 [details] [review]: Looks good as well.
Review of attachment 279474 [details] [review]: Looks good to me as well, though the cycle-foo bindings haven't worked properly for a long time and are now pretty much completely broken - so I wonder if it wouldn't make more sense to remove the default bindings rather than adding additional -backward ones ...
Pushed as a6f9ec2f4e6a4a59a8bd056c2356f04d381d3549 and 90438192bd1aaac1fef4b4153dabf2ca42b28cfb