After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732247 - Update hardcoded desktop filenames
Update hardcoded desktop filenames
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-25 21:12 UTC by Michael Catanzaro
Modified: 2014-07-22 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update hardcoded desktop filenames (2.49 KB, patch)
2014-06-25 21:12 UTC, Michael Catanzaro
none Details | Review
Update more hardcoded desktop file names (1.42 KB, patch)
2014-06-25 21:32 UTC, Michael Catanzaro
none Details | Review

Description Michael Catanzaro 2014-06-25 21:12:18 UTC
This might be a losing game, but this patch updates a bunch of hardcoded desktop filenames I found in gs-plugin-hardcoded-categories.c which have since changed.
Comment 1 Michael Catanzaro 2014-06-25 21:12:19 UTC
Created attachment 279266 [details] [review]
Update hardcoded desktop filenames
Comment 2 Michael Catanzaro 2014-06-25 21:32:13 UTC
Created attachment 279268 [details] [review]
Update more hardcoded desktop file names

I found another file with hardcoded desktop file names. Probably anywhere you do this, many will be broken.
Comment 3 Kalev Lember 2014-07-22 12:32:33 UTC
Thanks, I squashed those two together and pushed to master.

In related news, I added a mapping to gnome-shell to convert from old names to new ones, https://git.gnome.org/browse/gnome-shell/commit/?id=cceac0d8fbce8caa5e631c6204e0b2e0e4522bb3 -- can you spot anything missing there?

Also, we should probably look over this once again before 3.14.0 final release to see if anything else has changed their desktop names.
Comment 4 Michael Catanzaro 2014-07-22 12:51:18 UTC
I'll update that list with a few more GNOME games prior to 3.14 (might rename them again in the meantime if I switch them to D-Bus activation). For the others, there are just so many that it will be hard to keep that list updated. :/