GNOME Bugzilla – Bug 732242
Usage information provided in --help is invalid.
Last modified: 2014-06-25 20:10:48 UTC
Created attachment 279243 [details] [review] Patch which fixes the issue on master as of 963a1871f40760ebbb842e1740320045ab7c6e00. g_set_prgname() is being called with PACKAGE_NAME. so the usage section in --help is saying it can be executed with "Logs [OPTION...]". One solution is to remove the call altogether, and let gdk_init() handle setting prgname (which it does correctly). The patch provided here compiles correctly, and causes no obvious bugs. Furthermore, there are no explicit calls to g_get_prgname, so I suspect there are no unusual consumers which require it to be set to PACKAGE_NAME (which is "Logs") lurking anywhere inside gnome-logs itself.
This bug also applies to 3.12.2 stable.
Comment on attachment 279243 [details] [review] Patch which fixes the issue on master as of 963a1871f40760ebbb842e1740320045ab7c6e00. The argument to g_set_prgname() should not be translated, according to the documentation for that function, so the call can be made correct if you replace the argument with PACKAGE_TARNAME.
Created attachment 279248 [details] [review] Patch adjusted to embody David King's suggestions. This meets your suggestion, although I still don't think it's necessary to call it at all.
Comment on attachment 279248 [details] [review] Patch adjusted to embody David King's suggestions. Thanks for the patch, I pushed it to master as commit 121ca2690522b0ef3c087d84157fbd315aae4ac7.