After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732216 - mime type list in desktop file is wrong
mime type list in desktop file is wrong
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.13.x
Other All
: Normal blocker
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-25 10:09 UTC by Olav Vitters
Modified: 2014-06-25 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Olav Vitters 2014-06-25 10:09:43 UTC
configure.ac incorrectly combines multiple mime types, leading to things susch as: ;application/x-ext-pdfapplication/postscript;

I fixed it already in git, but probably want to do a 3.13.3.1 release.

Commit: https://git.gnome.org/browse/evince/commit/?id=74813a4c07c3b36565493bebc006fcd0d5e62aa9

Error log: http://pkgsubmit.mageia.org/uploads/rejected/cauldron/core/release/20140625095532.ovitters.valstar.3755.youri

Submission errors, aborting:
- evince-3.13.3-1.mga5:
 - invalid-desktopfile /usr/share/applications/evince-previewer.desktop value "application/pdf;application/x-bzpdf;application/x-gzpdf;application/x-xzpdf;application/x-ext-pdfapplication/postscript;application/x-bzpostscript;application/x-gzpostscript;image/x-eps;image/x-bzeps;image/x-gzeps;application/x-ext-ps;application/x-ext-epsapplication/x-dvi;application/x-bzdvi;application/x-gzdvi;application/x-ext-dviimage/vnd.djvu;application/x-ext-djv;application/x-ext-djvuimage/tiffapplication/x-cbr;application/x-cbz;application/x-cb7;application/x-cbt;application/x-ext-cbr;application/x-ext-cbz;application/x-ext-cb7;application/x-ext-cbtapplication/oxps;application/vnd.ms-xpsdocument" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
 - invalid-desktopfile /usr/share/applications/evince.desktop value "application/pdf;application/x-bzpdf;application/x-gzpdf;application/x-xzpdf;application/x-ext-pdfapplication/postscript;application/x-bzpostscript;application/x-gzpostscript;image/x-eps;image/x-bzeps;image/x-gzeps;application/x-ext-ps;application/x-ext-epsapplication/x-dvi;application/x-bzdvi;application/x-gzdvi;application/x-ext-dviimage/vnd.djvu;application/x-ext-djv;application/x-ext-djvuimage/tiffapplication/x-cbr;application/x-cbz;application/x-cb7;application/x-cbt;application/x-ext-cbr;application/x-ext-cbz;application/x-ext-cb7;application/x-ext-cbtapplication/oxps;application/vnd.ms-xpsdocument" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
 - invalid-desktopfile /usr/share/applications/evince-previewer.desktop value "application/pdf;application/x-bzpdf;application/x-gzpdf;application/x-xzpdf;application/x-ext-pdfapplication/postscript;application/x-bzpostscript;application/x-gzpostscript;image/x-eps;image/x-bzeps;image/x-gzeps;application/x-ext-ps;application/x-ext-epsapplication/x-dvi;application/x-bzdvi;application/x-gzdvi;application/x-ext-dviimage/vnd.djvu;application/x-ext-djv;application/x-ext-djvuimage/tiffapplication/x-cbr;application/x-cbz;application/x-cb7;application/x-cbt;application/x-ext-cbr;application/x-ext-cbz;application/x-ext-cb7;application/x-ext-cbtapplication/oxps;application/vnd.ms-xpsdocument" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
 - invalid-desktopfile /usr/share/applications/evince.desktop value "application/pdf;application/x-bzpdf;application/x-gzpdf;application/x-xzpdf;application/x-ext-pdfapplication/postscript;application/x-bzpostscript;application/x-gzpostscript;image/x-eps;image/x-bzeps;image/x-gzeps;application/x-ext-ps;application/x-ext-epsapplication/x-dvi;application/x-bzdvi;application/x-gzdvi;application/x-ext-dviimage/vnd.djvu;application/x-ext-djv;application/x-ext-djvuimage/tiffapplication/x-cbr;application/x-cbz;application/x-cb7;application/x-cbt;application/x-ext-cbr;application/x-ext-cbz;application/x-ext-cb7;application/x-ext-cbtapplication/oxps;application/vnd.ms-xpsdocument" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
Comment 1 Carlos Garcia Campos 2014-06-25 10:50:18 UTC
I didn't know the trailing semicolon was a requirement :-( Thanks for the patch, but unfortunately it's not correct, because it breaks the appdata backend files (the reason why I removed the trailing semicolon). Since it's a requirement of the desktop files, we can add the trailing ; to the desktop files instead.
Comment 2 Olav Vitters 2014-06-25 11:08:34 UTC
Don't forget that it wasn't only about the trailing comma. It is also that it was combining mime types incorrectly.

The following bit lacks a comma:
;application/x-ext-pdfapplication/postscript;
Comment 3 Olav Vitters 2014-06-25 11:08:47 UTC
eh.. semicolon
Comment 4 Carlos Garcia Campos 2014-06-25 11:13:10 UTC
(In reply to comment #2)
> Don't forget that it wasn't only about the trailing comma. It is also that it
> was combining mime types incorrectly.
> 
> The following bit lacks a comma:
> ;application/x-ext-pdfapplication/postscript;

Right, I read too fast, I'm trying a new patch
Comment 5 Carlos Garcia Campos 2014-06-25 11:17:12 UTC
Could you try again with current git master, please? I'll make a new release as soon as you confirm it works.
Comment 6 Olav Vitters 2014-06-25 11:30:16 UTC
Confirm all is fine. Checked both the desktop files as well as appdata.
Comment 7 Carlos Garcia Campos 2014-06-25 11:47:17 UTC
Thanks!