After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732197 - goo_canvas_get_bounds needs annotations for out arguments
goo_canvas_get_bounds needs annotations for out arguments
Status: RESOLVED FIXED
Product: goocanvas
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: goocanvas-maint
goocanvas-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-25 00:59 UTC by Simon Feltman
Modified: 2016-12-15 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Annotate goo_canvas_get_bounds arguments as out (1.30 KB, patch)
2014-06-25 01:03 UTC, Simon Feltman 		none Details | Review

Description Simon Feltman 2014-06-25 00:59:25 UTC 
The left, top, right, and bottom arguments of goo_canvas_item_raise should be marked as (out).
Comment 1 Simon Feltman 2014-06-25 01:01:50 UTC 
Paste mistake, should be goo_canvas_get_bounds.
Comment 2 Simon Feltman 2014-06-25 01:03:25 UTC 
Created attachment 279164 [details] [review]
Annotate goo_canvas_get_bounds arguments as out

Add (out) annotations to left, top, right, and bottom arguments.
Comment 3 Cédric Krier 2016-09-12 18:36:36 UTC 
Review of attachment 279164 [details] [review]:

LGTM
Comment 4 Cédric Krier 2016-09-12 18:42:05 UTC 
The patch works for me.
Indeed it is needed to be able to switch goocalendar to gir: https://goocalendar.tryton.org/bug4
Comment 5 Damon Chaplin 2016-12-15 11:54:14 UTC 
Patch applied. Thanks.

(Should they have "allow-none" as well?)
Comment 6 Cédric Krier 2016-12-15 12:22:51 UTC 
I think it should have "allow-none" like in the example: https://wiki.gnome.org/Projects/GObjectIntrospection/Annotations/Old#A.27out.27_parameters
Comment 7 Damon Chaplin 2016-12-15 21:05:56 UTC 
I've added (allow-none) to a few function parameters:

2016-12-15  Damon Chaplin  <damon@gnome.org>

	* src/goocanvastext.c (goo_canvas_text_get_natural_extents):
	* src/goocanvas.c (goo_canvas_render):
	* src/goocanvas.c (goo_canvas_get_bounds): added (allow-none)
	annotations for introspection.