GNOME Bugzilla – Bug 732189
Use AM_CPPFLAGS rather than INCLUDES
Last modified: 2014-06-25 13:09:42 UTC
This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279150 [details] [review] Use AM_CPPFLAGS rather than INCLUDES
Review of attachment 279150 [details] [review]: Can you split those in separate patches for each of the panels, and prefix the subject lines with the panel name (ditto for "shell"). And use "build: " as the prefix if there's left-overs.
Created attachment 279182 [details] [review] background: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279183 [details] [review] bluetooth: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279184 [details] [review] color: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279185 [details] [review] display: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279186 [details] [review] info: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279187 [details] [review] keyboard: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279188 [details] [review] mouse: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279189 [details] [review] network: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279190 [details] [review] notifications: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279191 [details] [review] online-accounts: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279192 [details] [review] power: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279193 [details] [review] printers: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279194 [details] [review] privacy: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279195 [details] [review] region: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279196 [details] [review] search: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279197 [details] [review] universal-access: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279198 [details] [review] wacom: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279199 [details] [review] shell: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279200 [details] [review] search-provider: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
I haven't updated the warning in each of the log to mention the correct filename, I can fix that up if you prefer (I did this through a script so I can adjust that fairly easily)
*** Bug 708111 has been marked as a duplicate of this bug. ***
Created attachment 279204 [details] [review] wacom: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279209 [details] [review] mouse: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279211 [details] [review] wacom: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Created attachment 279212 [details] [review] printers: Use AM_CPPFLAGS rather than INCLUDES This is deprecated in newer automake versions, and this causes warnings with automake 1.14: panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for AM_CPPFLAGS' (or '*_CPPFLAGS')
Attachment 279182 [details] pushed as 335f871 - background: Use AM_CPPFLAGS rather than INCLUDES Attachment 279183 [details] pushed as 0310748 - bluetooth: Use AM_CPPFLAGS rather than INCLUDES Attachment 279184 [details] pushed as 3679436 - color: Use AM_CPPFLAGS rather than INCLUDES Attachment 279185 [details] pushed as 492ebb5 - display: Use AM_CPPFLAGS rather than INCLUDES Attachment 279186 [details] pushed as 0de571b - info: Use AM_CPPFLAGS rather than INCLUDES Attachment 279187 [details] pushed as 74a09b9 - keyboard: Use AM_CPPFLAGS rather than INCLUDES Attachment 279189 [details] pushed as 32d2058 - network: Use AM_CPPFLAGS rather than INCLUDES Attachment 279190 [details] pushed as 53b8c0a - notifications: Use AM_CPPFLAGS rather than INCLUDES Attachment 279191 [details] pushed as 46b7358 - online-accounts: Use AM_CPPFLAGS rather than INCLUDES Attachment 279192 [details] pushed as 229ab01 - power: Use AM_CPPFLAGS rather than INCLUDES Attachment 279194 [details] pushed as 6f59e14 - privacy: Use AM_CPPFLAGS rather than INCLUDES Attachment 279195 [details] pushed as 1df05bd - region: Use AM_CPPFLAGS rather than INCLUDES Attachment 279196 [details] pushed as 1bfba25 - search: Use AM_CPPFLAGS rather than INCLUDES Attachment 279197 [details] pushed as eb3acad - universal-access: Use AM_CPPFLAGS rather than INCLUDES Attachment 279199 [details] pushed as c61d9e5 - shell: Use AM_CPPFLAGS rather than INCLUDES Attachment 279200 [details] pushed as 6c9cc17 - search-provider: Use AM_CPPFLAGS rather than INCLUDES Attachment 279209 [details] pushed as c67a8bf - mouse: Use AM_CPPFLAGS rather than INCLUDES Attachment 279211 [details] pushed as 2096cac - wacom: Use AM_CPPFLAGS rather than INCLUDES Attachment 279212 [details] pushed as 08c9ecd - printers: Use AM_CPPFLAGS rather than INCLUDES
Created attachment 279214 [details] [review] shell: Remove last reference to "INCLUDES" c61d9e5a95d replaced use of INCLUDES with AM_CPPFLAGS, but there was still one reference to INCLUDES in shell/Makefile.am. AM_CPPFLAGS will apply globally, so we don't need to explicitly set per-target CFLAGS/CPPFLAGS to its value.
Comment on attachment 279214 [details] [review] shell: Remove last reference to "INCLUDES" Attachment 279214 [details] pushed as 700889c - shell: Remove last reference to "INCLUDES"