GNOME Bugzilla – Bug 732176
drop support for ModemManager 0.7 [branch review: danw/mm1]
Last modified: 2014-06-27 15:56:40 UTC
danw/mm1 drops support for ModemManager 0.7, requiring MM 1.0, and thus requiring that libmm-glib be present at compile time if you want wwan/bluetooth support. (While it's probably time for this anyway, this work was a spinoff of the NM 1.0 API stuff; the MM 0.7 support still uses the deprecated NMSettingGsm properties, so if we're getting rid of them in libnm, we have to get rid of MM 0.7 support too.) With NMModemOld out of the way, we could collapse NMModemBroadband into NMModem, but I did not do that (yet?), and maybe there's some reason not to?
I'm fine with removing old MM support for NM 1.0. Note that this work will conflict with my dcbw/wwan-ipv6 branch (bug 682623). The only reason to keep NMModemBroadband separate from NMModem is Ubuntu/Canonical has done some work to add Ofono support to NetworkManager, and combining these two classes would pretty royally screw that. I'd say lets keep them separate for now, because Matthieu may get around to contributing that work soon. If that doesn't happen in a year we could consolidate. At least we're not changing external API. WRT to requiring libmm-glib, if people are really annoyed about that we could add a configure-time option that turns on/off the WWAN and BT-DUN support I guess.
(In reply to comment #1) > WRT to requiring libmm-glib, if people are really annoyed about that we could > add a configure-time option that turns on/off the WWAN and BT-DUN support I > guess. Yeah, I actually meant "requiring libmm-glib if you want wwan/bt support", not "requiring libmm-glib no matter what". If you don't have libmm-glib, it will just skip the wwan and bluetooth modules.
>> wwan: simplify variable names to not explicitly clarify MM 1.0 Seems to really just rename variables. Could you mention in the commit message that it is "trivial"? (if it really is) >> wwan, bluetooth: drop support for ModemManager 0.7 src/devices/wwan/Makefile.am still mentions WITH_MODEM_MANAGER_1 The rest LGTM
(In reply to comment #2) > (In reply to comment #1) > > WRT to requiring libmm-glib, if people are really annoyed about that we could > > add a configure-time option that turns on/off the WWAN and BT-DUN support I > > guess. > > Yeah, I actually meant "requiring libmm-glib if you want wwan/bt support", not > "requiring libmm-glib no matter what". If you don't have libmm-glib, it will > just skip the wwan and bluetooth modules. That's fine with me then.
Just a heads up; MM 0.7 was a pre-release/dev version of MM 1.0. The MMModemOld stuff was for MM 0.6.x.
doh, I somehow parsed "< 0.7" as meaning "<= 0.7" I pushed it to master right before noticing your comment. Oh well, I blame dcbw for not catching it in review :)
(In reply to comment #6) > doh, I somehow parsed "< 0.7" as meaning "<= 0.7" > > I pushed it to master right before noticing your comment. Oh well, I blame dcbw > for not catching it in review :) Ha :) No big deal I guess.
[for the record] was merged as: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=baab3cc64102c2966192502d5f2094edc94654d2