After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732150 - Remove custom player bar styling
Remove custom player bar styling
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-24 11:09 UTC by Allan Day
Modified: 2014-07-30 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port player and selection bar to GtkActionBar (32.15 KB, patch)
2014-07-29 08:48 UTC, Arnel Borja 		committed Details | Review

Description Allan Day 2014-06-24 11:09:23 UTC 
The player bar is styled using custom CSS that is shipped with music itself. This means that the player bar has an inconsistent appearance compared with the header bar, and means that it doesn't keep pace with theme-wide changes.

We now have action bars in GTK+. I would suggest either porting the player bar to be an ActionBar, or at least using the correct action bar CSS.
Comment 1 Arnel Borja 2014-07-29 08:48:15 UTC 
Created attachment 281918 [details] [review]
Port player and selection bar to GtkActionBar
Comment 2 Vadim Rutkovsky 2014-07-30 11:38:57 UTC 
Review of attachment 281918 [details] [review]:

Great, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=8a4572a

As a side note - I think we also had some patch which required bumping GTK requriement, right? I guess its best time to apply it also