GNOME Bugzilla – Bug 732126
cerbero: Add graphene recipe
Last modified: 2015-02-23 22:22:21 UTC
Created attachment 279066 [details] [review] Add graphene recipe graphene is used in master gst-plugins-bad as optional dependency. This patch adds support to build it in cerbero. When "--enable-introspection" is passed, graphene needs current gi master, so I disabled it in "prepare" for now. The setting of self.config.variants.gi seems only to change the one recipe and does not affect the others. Modifying the configure_tpl was not possible.
Created attachment 279067 [details] [review] Add gdk-pixbuf as dependency librsvg needed gdk-pixbuf for me
There are 2 recipes for librsvg, one that builds the pixbuf loader and one that doesn't. The later should not depend on gdk-pixbuf IIRC. Your patch still needs some work: * list the new plugin in the recipe * add it to -bad-static too * add the graphene libraries to the correspoding package.
Created attachment 281868 [details] [review] patch adding graphene added to as dependency to static plugins. added graphene to base system
Review of attachment 281868 [details] [review]: ::: recipes/graphene.recipe @@ +5,3 @@ + name = 'graphene' + remotes = {'origin': 'https://github.com/ebassi/graphene.git'} + commit = 'origin/master' commit should be origin/0.99.1 or whatever the tag for the 0.99.1 release is called
Created attachment 283998 [details] [review] add graphene recipe use 0.99.2 release
Comment on attachment 283998 [details] [review] add graphene recipe The patch does not apply to latest git master. And maybe we should first add it not to base-system but to wherever it is required (libgstgl? gl plugin?) Also please add a link to the bug to the commit message at the end
Created attachment 286966 [details] [review] patch adding graphene Rebased to current master and moved to packages/gstreamer-1.0-system.package.
commit a71a20507f1c4d47a532103faacd40b3abd36514 Author: Lubosz Sarnecki <lubosz@gmail.com> Date: Sat Jun 21 14:31:52 2014 +0200 recipes: add graphene https://bugzilla.gnome.org/show_bug.cgi?id=732126
Fails the build on Android ARM: https://jenkins.arracacha.collabora.co.uk/job/cerbero-android/1790/console raphene-alloc.c: In function 'graphene_alloc': In file included from graphene-config.h:38:0, from graphene-types.h:32, from graphene-matrix.h:27, from graphene-matrix.c:35: /home/jenkins/workspace/cerbero-android/workdir/android-ndk-r9d/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.8/include/arm_neon.h:32:2: error: #error You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) to use arm_neon.h #error You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) to use arm_neon.h However neon must only be used conditionally at runtime, not all Android devices have neon.
Also fails on OSX and Windows. I reported some bugs against graphene, and also updated the recipe to a later git commit which should fix the OSX problem.
Lubosz, should we try again with the latest version?
Android support has been merged: https://github.com/ebassi/graphene/issues/12 I guess the cerbero patch still applies?
Created attachment 297718 [details] [review] Revert "Revert "recipes: add graphene"" This reverts commit 5be16706ac3d3bfe927448275b74ceb0f3016ad7. Conflicts: recipes/gst-plugins-bad-1.0-static.recipe recipes/gst-plugins-bad-1.0.recipe
Created attachment 297719 [details] [review] Graphene: Update to current git commit Windows build has been fixed in latest commit.
latest git master builds fine on windows and android, just tested it.
Created attachment 297721 [details] [review] Graphene: enable static build
Thanks, commit e73f16e3fa307e37d475806365effa50c8027488 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Mon Feb 23 17:12:58 2015 -0500 Graphene: enable static build https://bugzilla.gnome.org/show_bug.cgi?id=732126 commit ff84fb8100bbd2bba92e0e0a8f66b599c06ab064 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Mon Feb 23 16:30:13 2015 -0500 Graphene: Update to current git commit Windows build has been fixed in latest commit. https://bugzilla.gnome.org/show_bug.cgi?id=732126 commit feebe71723f25e2a995c78072fa51b17e0abc235 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Mon Feb 23 16:28:35 2015 -0500 Revert "Revert "recipes: add graphene"" This reverts commit 5be16706ac3d3bfe927448275b74ceb0f3016ad7. Conflicts: recipes/gst-plugins-bad-1.0-static.recipe recipes/gst-plugins-bad-1.0.recipe https://bugzilla.gnome.org/show_bug.cgi?id=732126