After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732016 - Bad string construction
Bad string construction
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
: 732777 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-06-21 21:16 UTC by Marek Černocký
Modified: 2014-07-15 07:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dleyna: Do not use format constant (1.25 KB, patch)
2014-07-14 08:45 UTC, Juan A. Suarez Romero
committed Details | Review

Description Marek Černocký 2014-06-21 21:16:27 UTC
Construction

error = g_error_new (GRL_CORE_ERROR, GRL_CORE_ERROR_STORE_FAILED,
                     _("Upload failed, '%s', transferred %"G_GUINT64_FORMAT" bytes of %"G_GUINT64_FORMAT" bytes"),
                     upload_status, length, total);

in src/dleyna/grl-dleyna-source.c is unfriendly for gettext. Message is broken on macro G_GUINT64_FORMAT.
Comment 1 Bastien Nocera 2014-07-05 21:58:15 UTC
*** Bug 732777 has been marked as a duplicate of this bug. ***
Comment 2 Juan A. Suarez Romero 2014-07-14 08:45:30 UTC
Created attachment 280632 [details] [review]
dleyna: Do not use format constant

Make life easier for translators.
Comment 3 Juan A. Suarez Romero 2014-07-15 07:08:09 UTC
Comment on attachment 280632 [details] [review]
dleyna: Do not use format constant

committed