After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732011 - application: use gtk_application_set_accels_for_action
application: use gtk_application_set_accels_for_action
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-21 17:37 UTC by Pranav Kant
Modified: 2014-06-27 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
application: use gtk_application_set_accels_for_action (2.49 KB, patch)
2014-06-21 17:38 UTC, Pranav Kant
needs-work Details | Review
application: Use gtk_application_set_accels_for_action (2.50 KB, patch)
2014-06-27 10:07 UTC, Debarshi Ray
committed Details | Review

Description Pranav Kant 2014-06-21 17:37:57 UTC
... instead of using deprecated gtk_application_add_accelerator
Comment 1 Pranav Kant 2014-06-21 17:38:01 UTC
Created attachment 278900 [details] [review]
application: use gtk_application_set_accels_for_action

... instead of using deprecated gtk_application_add_accelerator
Comment 2 Debarshi Ray 2014-06-27 10:07:00 UTC
Review of attachment 278900 [details] [review]:

Thanks for the patch, Pranav.

::: src/photos-application.c
@@ +740,3 @@
   GVariant *state;
+  const gchar *quit_accels[2] = {"<Primary>q", NULL};
+  const gchar *fullscreen_accels[2] = {"F11", NULL};

Would be good to preserve the alphabetical order, if possible.

@@ +741,3 @@
+  const gchar *quit_accels[2] = {"<Primary>q", NULL};
+  const gchar *fullscreen_accels[2] = {"F11", NULL};
+  const gchar *gearMenu_accels[2] = {"F10", NULL};

No camel case, please. It should be gear_menu_accels.
Comment 3 Debarshi Ray 2014-06-27 10:07:49 UTC
Created attachment 279371 [details] [review]
application: Use gtk_application_set_accels_for_action