GNOME Bugzilla – Bug 732011
application: use gtk_application_set_accels_for_action
Last modified: 2014-06-27 10:08:17 UTC
... instead of using deprecated gtk_application_add_accelerator
Created attachment 278900 [details] [review] application: use gtk_application_set_accels_for_action ... instead of using deprecated gtk_application_add_accelerator
Review of attachment 278900 [details] [review]: Thanks for the patch, Pranav. ::: src/photos-application.c @@ +740,3 @@ GVariant *state; + const gchar *quit_accels[2] = {"<Primary>q", NULL}; + const gchar *fullscreen_accels[2] = {"F11", NULL}; Would be good to preserve the alphabetical order, if possible. @@ +741,3 @@ + const gchar *quit_accels[2] = {"<Primary>q", NULL}; + const gchar *fullscreen_accels[2] = {"F11", NULL}; + const gchar *gearMenu_accels[2] = {"F10", NULL}; No camel case, please. It should be gear_menu_accels.
Created attachment 279371 [details] [review] application: Use gtk_application_set_accels_for_action