After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732005 - Remove unused assignments
Remove unused assignments
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-06-21 11:29 UTC by Philip Withnall
Modified: 2014-06-22 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goption: Remove an unused assignment (888 bytes, patch)
2014-06-21 11:29 UTC, Philip Withnall 		committed Details | Review
gclosure: Remove an unused alloca() and assignment (850 bytes, patch)
2014-06-21 11:29 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-06-21 11:29:53 UTC 
Couple of trivial patches attached.
Comment 1 Philip Withnall 2014-06-21 11:29:55 UTC 
Created attachment 278888 [details] [review]
goption: Remove an unused assignment

Coverity issue: #1159514
Comment 2 Philip Withnall 2014-06-21 11:29:59 UTC 
Created attachment 278889 [details] [review]
gclosure: Remove an unused alloca() and assignment

Coverity issue: #1159511
Comment 3 Colin Walters 2014-06-22 00:17:18 UTC 
Review of attachment 278888 [details] [review]:

::: glib/goption.c
@@ +1190,3 @@
       {
+        get_change (context, G_OPTION_ARG_NONE,
+                    entry->arg_data);

It would make me happier if we explicitly cast to void here, as a hint to a future person looking at the code that we don't need the value.
Comment 4 Colin Walters 2014-06-22 00:20:05 UTC 
Review of attachment 278889 [details] [review]:

Right.  This was subtle.
Comment 5 Philip Withnall 2014-06-22 11:58:32 UTC 
Pushed with the (void) cast added.

Attachment 278888 [details] pushed as afea86a - goption: Remove an unused assignment
Attachment 278889 [details] pushed as 0950369 - gclosure: Remove an unused alloca() and assignment