After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732000 - gdatetime: Remove an unnecessary NULL pointer check
gdatetime: Remove an unnecessary NULL pointer check
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-06-21 09:30 UTC by Philip Withnall
Modified: 2017-05-02 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdatetime: Remove an unnecessary NULL pointer check (1008 bytes, patch)
2014-06-21 09:30 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-06-21 09:30:54 UTC 
Patch attached.
Comment 1 Philip Withnall 2014-06-21 09:30:57 UTC 
Created attachment 278883 [details] [review]
gdatetime: Remove an unnecessary NULL pointer check

datetime->tz can never be NULL, so this pointer check is unnecessary and
confusing, and messes up static analysis.
Comment 2 Philip Withnall 2017-05-02 22:46:56 UTC 
Nobody’s complained; I guess this can probably go in. 2017-me has reviewed it for 2014-me.

Attachment 278883 [details] pushed as b1cd337 - gdatetime: Remove an unnecessary NULL pointer check