After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731951 - Sometimes Ctrl-Q does not close the window
Sometimes Ctrl-Q does not close the window
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-20 08:54 UTC by Archil Imnadze
Modified: 2014-07-21 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for bug 731951. (1.07 KB, patch)
2014-07-08 07:03 UTC, Sagar Ghuge 		accepted-commit_now Details | Review
Fix Bug 73195 Sometimes Ctrl-Q does not close the window (1.05 KB, patch)
2014-07-21 09:39 UTC, Sagar Ghuge 		none Details | Review

Description Archil Imnadze 2014-06-20 08:54:15 UTC 
Steps to reproduce:
* Run the command: mkdir myfolder
* Run the command: gedit myfolder
* Wait for gedit to load and show the error that myfolder is a directory.
* Hit Ctrl-W to close the error.
* Hit Ctrl-Q.

Expected results:
Gedit should have been closed.

Actual results:
Nothing happends.
Comment 1 André Klapper 2014-06-20 12:35:48 UTC 
(In reply to comment #0)
> Steps to reproduce:
> * Run the command: mkdir myfolder
> * Run the command: gedit myfolder
> * Wait for gedit to load and show the error that myfolder is a directory.
> * Hit Ctrl-W to close the error.
> * Hit Ctrl-Q.
> 
> Expected results:
> Gedit should have been closed.
> 
> Actual results:
> Nothing happends.
Comment 2 Sagar Ghuge 2014-07-08 07:03:28 UTC 
Created attachment 280111 [details] [review]
Fix for bug 731951.

I think we should not check for the num_tab > 0 for the quit menu. We should enable this even if the num_tabs = 0.
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-07-08 07:08:45 UTC 
Review of attachment 280111 [details] [review]:

Looks good. Having no tabs should really not make it stop from quitting.
Comment 4 Sagar Ghuge 2014-07-21 09:39:10 UTC 
Created attachment 281290 [details] [review]
Fix Bug 73195 Sometimes Ctrl-Q does not close the window
Comment 5 Paolo Borelli 2014-07-21 10:30:46 UTC 
pushed