After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731946 - Removing a task result in error, but succeeds
Removing a task result in error, but succeeds
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
0.15.x
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-20 07:28 UTC by Milan Crha
Modified: 2014-06-20 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Handle SOUP_STATUS_NO_CONTENT in response to DELETE requests (1.19 KB, patch)
2014-06-20 09:50 UTC, Philip Withnall 		committed Details | Review
Log of the problem (2.18 KB, text/x-log)
2014-06-20 09:59 UTC, Philip Withnall 		  Details

Description Milan Crha 2014-06-20 07:28:56 UTC 
gdata_tasks_service_delete_task() fails to me with error
> Error code 204 when deleting an entry: No Content
but the task is properly removed from the server. This is with libgdata 0.15.1.

This error is returned as GDATA_SERVICE_ERROR_PROTOCOL_ERROR.

I'd say this particular error should be ignored.
Comment 1 Philip Withnall 2014-06-20 09:49:07 UTC 
Can you get a debug log which shows the problem please? I think I know where the fix needs to be, but I’d like to have a log for posterity. Thanks.

As always, please redact any personal data.

    LIBGDATA_DEBUG=3 G_MESSAGES_DEBUG=all evolution-calendar-factory -r -w &> my-log.log
Comment 2 Philip Withnall 2014-06-20 09:50:23 UTC 
Created attachment 278825 [details] [review]
core: Handle SOUP_STATUS_NO_CONTENT in response to DELETE requests

The Google Tasks API apparently returns HTTP status 204 in response to a
successful DELETE request on a task entry, rather than the status 200
which is returned by all the other services.

Handle the two statuses as equivalent.
Comment 3 Philip Withnall 2014-06-20 09:59:40 UTC 
Created attachment 278827 [details]
Log of the problem

For reference, here’s Milan’s log of the problem.
Comment 4 Philip Withnall 2014-06-20 10:03:12 UTC 
Milan tested it and reported the patch as working on IRC. Merged!

Attachment 278825 [details] pushed as aaafd11 - core: Handle SOUP_STATUS_NO_CONTENT in response to DELETE requests