After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731941 - Add sample data needed by tests
Add sample data needed by tests
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks: 736414
 
 
Reported: 2014-06-19 22:17 UTC by Martin Simon
Modified: 2016-02-20 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample data needed by tests - draft (236.09 KB, patch)
2014-06-19 22:17 UTC, Martin Simon
none Details | Review

Description Martin Simon 2014-06-19 22:17:48 UTC
Created attachment 278811 [details] [review]
Sample data needed by tests - draft

I've added test set testing basic functionality of gnome-software. Unfortunately, these tests need some sample data to search and browse them. There is a way to get them, using data/Makefile with parameter 'install-sample-data'. But the problem is, GnomeContinuous has no network so this is not gonna work.

An option is to get archive, decrease the size (e.g. keep only default name and remove all other language versions) and commit it to upstream repo. This is not a big deal, I tried it and the archive could about 200kB size.

Problem is that I don't know how to pass it into these Makefile/configure/m4 or whatever to make it install under GnomeContinuous. They should be installed only under GnomeContinuous (it means, it shouldn't be probably installed when someone clones the upstream repo and wants to execute tests).

I also attached some kind of patch draft. It's working, but it's missing the Makefile/configure/m4 magic as I'm not familiar with it enough to do that. Also sorry for the binary, it's compressed archive which is originally over 1MB. I'm afraid it could be also problem (to have binary in upstream repo), I guess.
Comment 1 Richard Hughes 2014-08-06 15:33:33 UTC
Is there any env var for running under continuous? Installing 200kB for installed tests seems like a large overhead.
Comment 2 Martin Simon 2014-08-13 19:35:04 UTC
well, installing of these tests and sample data is relevant only when compiling with "--enable-installed-tests" parameter of configure script. So, if I understand it well, the only problem you see is in installing the sample data when not needed (e.g. when gnome-software is installed as a regular package)?

I would like to solve it by downloading the data when needed, but that's not possible under GnomeContinuous, unfortunately..
Comment 3 Richard Hughes 2016-02-20 20:51:42 UTC
We have xdg-app metadata now :)