After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731933 - Disable all shortcuts at once
Disable all shortcuts at once
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Keybindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on: 733292
Blocks:
 
 
Reported: 2014-06-19 18:41 UTC by Matthias Clasen
Modified: 2014-08-21 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow disabling shortcuts (7.33 KB, patch)
2014-08-11 00:52 UTC, Matthias Clasen
reviewed Details | Review
Allow disabling shortcuts (9.80 KB, patch)
2014-08-21 01:09 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2014-06-19 18:41:35 UTC
From a downstream feature request:

Would be nice if there was a checkbox that disabled all shortcuts so that I could turn them all off at once, but then turn them all back on without having to delete them all and recreate them. Another option would be to have the profiles support shortcuts, so I could have a profile with "no-shortcuts."

Sometimes you need to actually use the keys that the shortcuts are bound to as their actual selves but you don't want to kill the shortcuts forever, this is very difficult in the current design.
Comment 1 Christian Persch 2014-06-19 19:04:10 UTC
Sure. Since g-t is using GtkApplication accelerators, would IMHO be best to make that a GtkApplication property ('enable-accelerators' or so).
Comment 2 Matthias Clasen 2014-07-21 15:43:42 UTC
Doesn't 

g_object_set (gtk_settings_get_default (), "gtk-enable-accels", FALSE, NULL);

already do just that ?
Comment 3 Matthias Clasen 2014-08-11 00:52:52 UTC
Created attachment 283054 [details] [review]
Allow disabling shortcuts

Just like mnemonics, shortcuts can sometimes interfere with
applications running in the terminal.
Comment 4 Christian Persch 2014-08-16 17:27:51 UTC
Comment on attachment 283054 [details] [review]
Allow disabling shortcuts

Looks fine.

The only think missing is IMHO that this should also set the shortcut editor widget insensitive in the prefs dialogue when enabled.
Comment 5 Christian Persch 2014-08-16 17:28:12 UTC
Err, when shortcuts are DISabled.
Comment 6 Matthias Clasen 2014-08-21 01:09:23 UTC
Created attachment 284030 [details] [review]
Allow disabling shortcuts

Just like mnemonics, shortcuts can sometimes interfere with
applications running in the terminal.
Comment 7 Matthias Clasen 2014-08-21 01:10:52 UTC
New version does disable editing shortcuts when shortcuts are disabled. I've also moved the check button to the shortcuts tab, to make it more obvious why editing does not work.
Comment 8 Matthias Clasen 2014-08-21 17:29:56 UTC
Attachment 284030 [details] pushed as 8e66bca - Allow disabling shortcuts