GNOME Bugzilla – Bug 731923
The calendar is revers in RTL in git master
Last modified: 2014-06-24 22:04:34 UTC
Since https://git.gnome.org/browse/gnome-shell/commit/js/ui/calendar.js?id=ec714864f2041ff1d128f4a3c3e457275264ebe4 (I think this is this commit cause the bug) the calendar look wrong in RTL. In RTL I wants to see the week starts in the right side (Sunday in the right side) and ends in the left side (Saturday in the left side). Now the calender look in RTL same to LTR (start in left and end in right). it wrong, and I think it caused by the commit I mention above.
Created attachment 278840 [details] RTL calendar So for clarification - does the attached screenshot look correct for he_IL, or should the actual calendar use the same layout as LTR, e.g. only the weekdate should be mirrored as in the bug description?
It look better. but it still wrong. If A it Sunday and G is Saturday, in Hebrew א = A = Sunday and ש = G = Saturday, so what I see in your screenshot is: ג ד ה ו ש א ב But I need to see: א ב ג ד ה ו ש It mean the two last days (א ב) needs to be at the start (in the right side), before the ג day. I'm hope it clear.
Created attachment 278841 [details] RTL calendar, 2nd shot Ah yes, I forget the header and running with the correct LC_TIME - how about this then?
It great, it exactly how it look in the calendar widget in GTK+ (see in gtk3-widget-factory). Thanks!
Created attachment 278842 [details] [review] calendar: Fix for RTL locales Unlike StTable, ClutterTableLayout does not take the actor's text direction into account, so mirror columns ourselves now.
Created attachment 278843 [details] [review] calendar: Fix events for RTL locales Unlike StTable, ClutterTableLayout does not take the actor's text direction into account, so mirror columns ourselves now.
Created attachment 278844 [details] [review] networkAgent: Fix layout for RTL locales Unlike StTable, ClutterTableLayout does not take the actor's text direction into account, so mirror columns ourselves now.
Created attachment 278845 [details] [review] appDisplay: Fix folder icons for RTL locales Unlike StTable, ClutterTableLayout does not take the actor's text direction into account, so mirror columns ourselves now.
I can to confirm, it works very well, it look just nice! Thanks!
Attachment 278842 [details] pushed as 6077e28 - calendar: Fix for RTL locales Attachment 278843 [details] pushed as 256bb53 - calendar: Fix events for RTL locales Attachment 278844 [details] pushed as 8abd183 - networkAgent: Fix layout for RTL locales Attachment 278845 [details] pushed as 2bda6db - appDisplay: Fix folder icons for RTL locales