After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731922 - use separate PKG_CHECK_MODULES calls for separate libs
use separate PKG_CHECK_MODULES calls for separate libs
Status: RESOLVED WONTFIX
Product: libcroco
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-19 15:51 UTC by Marcin Wojdyr
Modified: 2015-10-31 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Marcin Wojdyr 2014-06-19 15:51:48 UTC 
please consider changing this:

PKG_CHECK_MODULES([CROCO],[
  glib-2.0 >= $GLIB_REQUIRED
  libxml-2.0 >= $LIBXML_REQUIRED])

to two calls, for example:

PKG_CHECK_MODULES([GLIB2],[glib-2.0 >= $GLIB_REQUIRED])
PKG_CHECK_MODULES([LIBXML2],[libxml-2.0 >= $LIBXML_REQUIRED])

It would make building easier when I'm missing .pc file for libxml2 (on OSX the system version of libxml2 has no pc file).

Also, having CROCO as the first arg generates inaccurate message:
Checking for CROCO...
Comment 1 Ignacio Casal Quinteiro (nacho) 2015-10-31 19:15:29 UTC 
Dunno, this is like this for other modules and libxml2 is a normal dep for the library. I will change really nothing about this since anyway configure will complain that you are missing libxml2 and it will abort. Thanks for reporting though.
Comment 2 Marcin Wojdyr 2015-10-31 19:43:22 UTC 
Maybe I should have explained it in details: when a library is installed without the corresponding pc file, one can specify location of the library and its headers through environment variables, in case of libxml2 that would normally be LIBXML2_CFLAGS and LIBXML2_LIBS. But it's not so easy if PKG_CHECK_MODULES is called with multiple libraries.
Comment 3 Ignacio Casal Quinteiro (nacho) 2015-10-31 19:46:48 UTC 
dunno, this is the same for other libraries i.e:
https://git.gnome.org/browse/gtksourceview/tree/configure.ac#n97

I guess should fix your build system to have the pc file. Why don't you use jhbuild on osx?