GNOME Bugzilla – Bug 731921
gl: Port glmixer to the GstVideoAggregator baseclass
Last modified: 2014-06-25 00:11:28 UTC
The new GstVideoAggregator base class feets perfectly for the glmixer base class and removes quite a lot of code.
Created attachment 278778 [details] [review] gl: Port glmixer to the GstVideoAggregator baseclass
You can find a branch with all the related commits at: https://gitlab.com/thiblahute/gst-plugins-bad/commits/aggregator
commit 4ce8b409cc30d80c5d6ce949965789036e2269d6 Author: Thibault Saunier <tsaunier@gnome.org> Date: Tue Jun 10 11:26:53 2014 +0200 gl: Port glmixer to the GstVideoAggregator baseclass https://bugzilla.gnome.org/show_bug.cgi?id=731921
This appears to be non-functional for me with git master: gst-launch-1.0 mix. ! queue ! glimagesink \ gltestsrc pattern=black ! video/x-raw,width=1280,height=720 ! queue name=background \ gltestsrc pattern=smpte ! glfiltercube ! video/x-raw,width=1280,height=720 ! glcolorscale ! video/x-raw,width=640,height=720 ! queue name=left \ gltestsrc pattern=smpte ! glfilterglass ! video/x-raw,width=1280,height=720 ! glcolorscale ! video/x-raw,width=640,height=720 ! queue name=right \ background. ! mix.sink_0 \ left. ! mix.sink_1 \ right. ! mix.sink_2 \ glvideomixer name=mix sink_2::xpos=640 (gst-launch-1.0:65455): GStreamer-CRITICAL **: Padname sink_4294967295 is not unique in element mix, not adding (gst-launch-1.0:65455): GStreamer-CRITICAL **: Padname sink_4294967295 is not unique in element mix, not adding WARNING: erroneous pipeline: could not link left to mix The same pipeline works fine if I just swap out glvideomixer for videomixer. Do you think this is related or should it be reported as a separate issue? It would be nice to have glvideomixer functioning properly for 1.4.0 I think. :)
(In reply to comment #4) > This appears to be non-functional for me with git master: > > gst-launch-1.0 mix. ! queue ! glimagesink \ > gltestsrc pattern=black ! video/x-raw,width=1280,height=720 ! queue > name=background \ > gltestsrc pattern=smpte ! glfiltercube ! video/x-raw,width=1280,height=720 ! > glcolorscale ! video/x-raw,width=640,height=720 ! queue name=left \ > gltestsrc pattern=smpte ! glfilterglass ! video/x-raw,width=1280,height=720 ! > glcolorscale ! video/x-raw,width=640,height=720 ! queue name=right \ > background. ! mix.sink_0 \ > left. ! mix.sink_1 \ > right. ! mix.sink_2 \ > glvideomixer name=mix sink_2::xpos=640 > > (gst-launch-1.0:65455): GStreamer-CRITICAL **: Padname sink_4294967295 is not > unique in element mix, not adding > > (gst-launch-1.0:65455): GStreamer-CRITICAL **: Padname sink_4294967295 is not > unique in element mix, not adding > WARNING: erroneous pipeline: could not link left to mix > > The same pipeline works fine if I just swap out glvideomixer for videomixer. > > Do you think this is related or should it be reported as a separate issue? It > would be nice to have glvideomixer functioning properly for 1.4.0 I think. :) This has been fixed with: commit 6409641130e008c7c48c5f97da34e1d21a8f1698 Author: Thibault Saunier <tsaunier@gnome.org> Date: Sat Jun 21 13:45:13 2014 +0200 aggregator: Fix requested pad name Pretty nice pipeline btw :)
Right, that fixed it for gltestsrc. I'll file a new ticket for avfvideosrc.