After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731848 - ClutterGst 3.0 port
ClutterGst 3.0 port
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
Depends on:
Blocks: 515240
 
 
Reported: 2014-06-18 12:49 UTC by Lionel Landwerlin
Modified: 2014-12-07 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backend: port to clutter-gst 3.0 (3.63 KB, patch)
2014-06-18 12:50 UTC, Lionel Landwerlin 		accepted-commit_after_freeze Details | Review

Description Lionel Landwerlin 2014-06-18 12:49:42 UTC 
Just a quick patch to port Totem to ClutterGst 3.0.

ClutterGst 3.0 brings some nice features on the performance side :

- Color correction using GL shaders
- Overlay support for subtitles (prevents the CPU to write on the video frame for every frame)
- Ability to display the same video stream multiple times in the scenegraph (or even different scenegraphs https://www.youtube.com/watch?v=nqCRgNF2C9o)

All the features above are part of an effort to get vaapi plugins to work out of the box. I'm pretty confident we'll make that happen for 3.14 (and GStreamer 1.4).
Comment 1 Lionel Landwerlin 2014-06-18 12:50:50 UTC 
Created attachment 278675 [details] [review]
backend: port to clutter-gst 3.0
Comment 2 Bastien Nocera 2014-09-04 01:41:37 UTC 
Review of attachment 278675 [details] [review]:

If it's been tested, looks good for 3.16.

::: src/backend/bacon-video-widget.c
@@ +5957,3 @@
+  bvw->priv->texture = g_object_new (CLUTTER_TYPE_ACTOR,
+                                     "content",
+                                     g_object_new (CLUTTER_GST_TYPE_CONTENT,

Put that on the line above, and it all looks good.
Comment 3 Bastien Nocera 2014-11-25 23:44:24 UTC 
Are we doing ClutterGst 3.0 for GNOME 3.16 then?
Comment 4 Lionel Landwerlin 2014-11-26 21:16:23 UTC 
Sure, let me just rebase the totem patch if needed and release 3.0.
Thanks.
Comment 5 Lionel Landwerlin 2014-12-07 00:05:45 UTC 
Push to master. Thanks.
Comment 6 Bastien Nocera 2014-12-07 17:15:29 UTC 
(In reply to comment #5)
> Push to master. Thanks.

Hmm, you forgot to branch ;)

Are there any changes necessary on the totem side other than the ones in your patch to get the features mentioned in comment 0? In particular, can we close bug 515240?
Comment 7 Lionel Landwerlin 2014-12-07 17:29:46 UTC 
Thanks for the branch reminder.

All of the items in comment 0 are available, that include vaapi support (which might not be that reliable and could even consume more power than decoding in software... but that's another problem and you can disable that support with --enable-gl-texture-upload=no), and yes you can close bug 515240 (you can see subtitles textures being composed by GL using : COGL_DEBUG=rectangles totem).
Comment 8 Bastien Nocera 2014-12-07 17:55:13 UTC 
(In reply to comment #7)
> Thanks for the branch reminder.
> 
> All of the items in comment 0 are available, that include vaapi support (which
> might not be that reliable and could even consume more power than decoding in
> software... but that's another problem and you can disable that support with
> --enable-gl-texture-upload=no),

Do you have a bug number to track that?

> and yes you can close bug 515240 (you can see
> subtitles textures being composed by GL using : COGL_DEBUG=rectangles totem).

Cool, thanks!
Comment 9 Lionel Landwerlin 2014-12-07 18:11:20 UTC 
https://bugzilla.gnome.org/show_bug.cgi?id=732015