After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731826 - vapigen fails to find Rsvg-2.0-custom.vala when building out-of-source
vapigen fails to find Rsvg-2.0-custom.vala when building out-of-source
Status: RESOLVED DUPLICATE of bug 725497
Product: vala
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-18 08:01 UTC by Michał Górny
Modified: 2016-09-20 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the issue by using fully-qualified path (1.04 KB, patch)
2014-06-18 08:01 UTC, Michał Górny
none Details | Review

Description Michał Górny 2014-06-18 08:01:03 UTC
Created attachment 278658 [details] [review]
Patch fixing the issue by using fully-qualified path

How to reproduce:

  mkdir _build
  cd _build
  ../configure -C --enable-vala
  make V=1

This result in the following error:

make[2]: Entering directory '/tmp/librsvg/_build'
/usr/bin/vapigen-0.24  --library librsvg-2.0 --metadatadir ..   --pkg gio-2.0 --pkg cairo Rsvg-2.0.gir Rsvg-2.0-custom.vala
error: Rsvg-2.0-custom.vala not found
Generation failed: 1 error(s), 0 warning(s)
/usr/share/vala/Makefile.vapigen:61: recipe for target 'librsvg-2.0.vapi' failed
make[2]: *** [librsvg-2.0.vapi] Error 1

I've been able to fix this via prepending the 'Rsvg-2.0-custom.vala' file path in Makefile.am with $(srcdir).
Comment 1 Christian Persch 2014-06-22 13:09:31 UTC
Hmm. IMHO this is a bug in the Makefile.vapigen, it should automatically adapt to *_FILES being a mix of srcdir and builddir files.
Comment 2 Evan Nemerson 2014-06-27 20:39:58 UTC
(In reply to comment #1)
> Hmm. IMHO this is a bug in the Makefile.vapigen, it should automatically adapt
> to *_FILES being a mix of srcdir and builddir files.

How?  Is there anything which does?
Comment 3 Christian Persch 2014-06-28 08:05:39 UTC
Almost everything in automake is able to automatically cope with a mix of srcdir and builddir files, e.g. most importantly _SOURCES .
Comment 4 Luca Bruno 2014-06-28 08:09:47 UTC
Relevant:  https://bugzilla.gnome.org/show_bug.cgi?id=725497
Comment 5 Pacho Ramos 2016-01-10 18:12:53 UTC
Can this be committed or should we wait for bug 725497 instead?
Comment 6 Rico Tzschichholz 2016-09-20 14:44:41 UTC

*** This bug has been marked as a duplicate of bug 725497 ***