After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731804 - Fix the button's icons in RTL
Fix the button's icons in RTL
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-17 23:20 UTC by Yosef Or Boczko
Modified: 2014-06-23 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
yelp-window: Fix the button's icons in RTL (2.60 KB, patch)
2014-06-17 23:20 UTC, Yosef Or Boczko 		rejected Details | Review
yelp-window: Use the new support for RTL icons in GtkIconTheme (2.27 KB, patch)
2014-06-18 18:29 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2014-06-17 23:20:12 UTC 
GTK+ 3.13 handl himself in RTL icons, and we needs to fix the code to
work with this.

For now I make a bit tricky code, so the code work with GTK+ 3.12 and 3.13 too.
Comment 1 Yosef Or Boczko 2014-06-17 23:20:39 UTC 
Created attachment 278635 [details] [review]
yelp-window: Fix the button's icons in RTL
Comment 2 Yosef Or Boczko 2014-06-18 18:29:20 UTC 
Created attachment 278710 [details] [review]
yelp-window: Use the new support for RTL icons in GtkIconTheme

Since we now dependen in GTK+ 3.13.3, I can just to remove the rtl handling.
Comment 3 Yosef Or Boczko 2014-06-18 18:31:03 UTC 
Review of attachment 278635 [details] [review]:

.
Comment 4 Shaun McCance 2014-06-23 22:02:00 UTC 
Thanks