After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731721 - Reorder junk filtering configuration UI
Reorder junk filtering configuration UI
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-06-16 13:05 UTC by Michael Ekstrand
Modified: 2014-06-18 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
how it looks after the change (75.80 KB, image/png)
2014-06-18 08:43 UTC, Milan Crha
Details
much better like this (78.12 KB, image/png)
2014-06-18 09:08 UTC, Milan Crha
Details

Description Michael Ekstrand 2014-06-16 13:05:45 UTC
In conjunction with #731720, I think it would be good to re-order the junk filtering UI to more transparently model a useful order of junk tests.  Something like this:

* Keep 'Check incoming messages for junk' as the top, top-level
  check box.  Have it enable/disable the following options, which
  are indented under it:
  * 'Skip junk detection if sender is in my address book'
    * 'Lookup in local address book only'
  * 'Check custom headers for junk flags'
  * 'Use external junk filter' <drop-down> (invisible if no
    plugin available, junk filter config UI is subordinate
    to this checkbox)
* 'Delete junk messages' as top-level sibling of 'Check…', at the
  bottom of the pane
* Get rid of the 'Option is ignored…' notice

Reference: https://mail.gnome.org/archives/evolution-hackers/2013-November/msg00016.html
Comment 1 Milan Crha 2014-06-18 08:43:30 UTC
Created attachment 278659 [details]
how it looks after the change

It looked odd with "Delete junk messages" at the bottom, thus I moved it at the very top, as can be seen in this screenshot.
Comment 2 Milan Crha 2014-06-18 09:08:52 UTC
Created attachment 278662 [details]
much better like this

Nah, the options under "Check incoming messages for junk" cannot be disable, because users can invoke junk test in a message filter, not only when automatically checking for junk.

Thus I added section "junk Test Options" and it looks much better now.
Comment 3 Milan Crha 2014-06-18 09:11:38 UTC
Created commit 1cb6d79 in evo master (3.13.3+) [1]

[1] https://git.gnome.org/browse/evolution/commit/?id=1cb6d79