After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731713 - Use higher resolution thumbnails on HiDpi displays
Use higher resolution thumbnails on HiDpi displays
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
3.12.x
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-16 10:21 UTC by Debarshi Ray
Modified: 2014-06-17 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
background: Use higher resolution thumbnails on HiDpi displays (19.38 KB, patch)
2014-06-16 12:43 UTC, Debarshi Ray
needs-work Details | Review
background: Remove empty property getters and setters (3.54 KB, patch)
2014-06-17 11:30 UTC, Debarshi Ray
committed Details | Review
background: Rearrange the GObject boilerplate (3.37 KB, patch)
2014-06-17 11:30 UTC, Debarshi Ray
committed Details | Review
background: Use higher resolution thumbnails on HiDpi displays (13.54 KB, patch)
2014-06-17 11:31 UTC, Debarshi Ray
committed Details | Review
background: Remove unnecessary initialization (1.17 KB, patch)
2014-06-17 11:40 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-06-16 10:21:57 UTC
Got a ChromeBook Pixel here and the thumbnails in CcBackgroundChooserDialog look smaller. We should scale them up.
Comment 1 Debarshi Ray 2014-06-16 12:43:08 UTC
Created attachment 278536 [details] [review]
background: Use higher resolution thumbnails on HiDpi displays

Tested on gnome-3-12 because I don't have a full development environment set up on this machine, yet. But it applies against master too.
Comment 2 Bastien Nocera 2014-06-16 13:31:10 UTC
Review of attachment 278536 [details] [review]:

I'd rather this was all done piecemeal.

::: panels/background/bg-colors-source.c
@@ -34,3 @@
 
-static void
-bg_colors_source_class_init (BgColorsSourceClass *klass)

Move this in a separate commit.

::: panels/background/bg-wallpapers-source.c
@@ -43,2 @@
 static void
-bg_wallpapers_source_get_property (GObject    *object,

Remove this...

@@ -55,3 @@
-
-static void
-bg_wallpapers_source_set_property (GObject      *object,

...and this in a separate commit.

@@ -79,3 @@
-
-static void
-bg_wallpapers_source_class_init (BgWallpapersSourceClass *klass)

Ditto about moving the functions.

::: panels/background/cc-background-chooser-dialog.c
@@ +448,2 @@
   object_class = G_OBJECT_CLASS (klass);
+  object_class->constructed = cc_background_chooser_dialog_constructed;

You don't need to use constructed here, the dialog doesn't have any properties, so the state after init will be the same as after constructed.
Comment 3 Debarshi Ray 2014-06-17 11:29:16 UTC
(In reply to comment #2)
> Review of attachment 278536 [details] [review]:

Thanks for the review, Bastien.

> ::: panels/background/bg-colors-source.c
> @@ -34,3 @@
> 
> -static void
> -bg_colors_source_class_init (BgColorsSourceClass *klass)
> 
> Move this in a separate commit.

Done.

> ::: panels/background/bg-wallpapers-source.c
> @@ -43,2 @@
>  static void
> -bg_wallpapers_source_get_property (GObject    *object,
> 
> Remove this...
> 
> @@ -55,3 @@
> -
> -static void
> -bg_wallpapers_source_set_property (GObject      *object,
> 
> ...and this in a separate commit.

Done.

> @@ -79,3 @@
> -
> -static void
> -bg_wallpapers_source_class_init (BgWallpapersSourceClass *klass)
> 
> Ditto about moving the functions.

Done.

> ::: panels/background/cc-background-chooser-dialog.c
> @@ +448,2 @@
>    object_class = G_OBJECT_CLASS (klass);
> +  object_class->constructed = cc_background_chooser_dialog_constructed;
> 
> You don't need to use constructed here, the dialog doesn't have any properties,
> so the state after init will be the same as after constructed.

Oops, yes, you are right.
Comment 4 Debarshi Ray 2014-06-17 11:30:04 UTC
Created attachment 278586 [details] [review]
background: Remove empty property getters and setters
Comment 5 Debarshi Ray 2014-06-17 11:30:41 UTC
Created attachment 278587 [details] [review]
background: Rearrange the GObject boilerplate
Comment 6 Debarshi Ray 2014-06-17 11:31:23 UTC
Created attachment 278588 [details] [review]
background: Use higher resolution thumbnails on HiDpi displays
Comment 7 Debarshi Ray 2014-06-17 11:40:32 UTC
Created attachment 278589 [details] [review]
background: Remove unnecessary initialization
Comment 8 Bastien Nocera 2014-06-17 12:14:17 UTC
Review of attachment 278586 [details] [review]:

++
Comment 9 Bastien Nocera 2014-06-17 12:14:54 UTC
Review of attachment 278587 [details] [review]:

Looks good
Comment 10 Bastien Nocera 2014-06-17 12:18:11 UTC
Review of attachment 278588 [details] [review]:

Looks good
Comment 11 Bastien Nocera 2014-06-17 12:18:37 UTC
Review of attachment 278589 [details] [review]:

++
Comment 12 Debarshi Ray 2014-06-17 16:59:49 UTC
Thanks for the reviews, Bastien.