After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731707 - tsdemux: remove unused const variables
tsdemux: remove unused const variables
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-16 09:25 UTC by Matthieu Bouron
Modified: 2014-06-22 11:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tsdemux: remove unused const variables (1.36 KB, patch)
2014-06-16 09:26 UTC, Matthieu Bouron 		none Details | Review
tsdemux: remove unused const variables (1.39 KB, patch)
2014-06-16 09:49 UTC, Matthieu Bouron 		reviewed Details | Review

Description Matthieu Bouron 2014-06-16 09:25:42 UTC 
Remove unused const variables which are reported as errors by clang on osx 10.9.
I'm not sure if those variable are really useful or not.
Comment 1 Matthieu Bouron 2014-06-16 09:26:20 UTC 
Created attachment 278520 [details] [review]
tsdemux: remove unused const variables
Comment 2 Tim-Philipp Müller 2014-06-16 09:30:36 UTC 
/* Return offset of ... */
gboolean ...

Doesn't look quite right yet :)
Comment 3 Matthieu Bouron 2014-06-16 09:49:41 UTC 
Created attachment 278521 [details] [review]
tsdemux: remove unused const variables

Update description of GstTsDemuxKeyFrameScanFunction.
Comment 4 Tim-Philipp Müller 2014-06-22 11:35:09 UTC 
Looks like Sebastian fixed it independently and made the same mistake :) In any case, fixed now. (Didn't take your patch because it didn't apply any more and because the wording was specific to H.264 but the function is generic theoretically)