After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731698 - tsdemux : latest patch for accurate seeking of h264 streams has been incorrectly merged.
tsdemux : latest patch for accurate seeking of h264 streams has been incorrec...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-15 21:39 UTC by Mathieu Duponchelle
Modified: 2014-06-16 05:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes the reported issue (966 bytes, patch)
2014-06-15 21:40 UTC, Mathieu Duponchelle 		rejected Details | Review

Description Mathieu Duponchelle 2014-06-15 21:39:07 UTC 
Reproduction:

gst-validate-1.0 playbin uri=file:///home/meh/devel/some_MTS_with_h264 --set-scenario scrub_forward_seeking

What should happen : progressive seeking along the file.

What happens : playback stays stuck at the first picture.

Caused by 0020a9344d53a5298c486817171f3aecf6c55249 (tsdemux: Remove unused variable) and the modification of the proposed patch, which actually used that variable, to account for this change.

I propose reverting 0020a9344d53a5298c486817171f3aecf6c55249 and merging the patch I'll attach.
Comment 1 Mathieu Duponchelle 2014-06-15 21:40:47 UTC 
Created attachment 278503 [details] [review]
fixes the reported issue
Comment 2 Edward Hervey 2014-06-16 05:44:39 UTC 
The problem comes from the fact that 'start' gets modified before being set on the segment.

commit 1d1d4694889fd78534561829ac504425b63ac2ad
Author: Edward Hervey <edward@collabora.com>
Date:   Mon Jun 16 07:42:37 2014 +0200

    tsdemux: Don't overwrite original seek value
    
    In accurate mode, we'll be using start to fill in the seek segment,
    therefore don't overwrite it with the shifted seek position.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731698