After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731676 - add metainfo files for all available plugins
add metainfo files for all available plugins
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-15 07:32 UTC by Igor Gnatenko
Modified: 2019-02-22 03:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
plugins: add metainfo for all available plugins (26.96 KB, patch)
2014-06-15 10:23 UTC, Igor Gnatenko
none Details | Review
plugins: add metainfo for all available plugins (26.96 KB, patch)
2014-06-15 10:33 UTC, Igor Gnatenko
none Details | Review
plugins: add metainfo for all available plugins (28.18 KB, patch)
2014-06-16 10:11 UTC, Igor Gnatenko
needs-work Details | Review

Description Igor Gnatenko 2014-06-15 07:32:51 UTC
Hi,

Recently Richard Hughes added the addon component type to AppStream[1]
which is an XML standard that is used by distributors such as Fedora,
Suse and soon to be Arch and Debian to create metadata for various
software center applications.

By creating a metainfo.xml for each plugin, these are then shown next to
the main "eog" application and allow the user to easily install
extra components.

Richard written a blog post[2] about what upstream software needs to do
to integrate with the KDE and GNOME software centers, and Richard really
appreciate any feedback and help at this stage. The way AppStream works
is that it has to be build upstream by the distro, so we'd need to have
the files either upstream (or downstream in the distro packages) by
GNOME 3.14 which is quite a few months away.

[1]http://www.freedesktop.org/software/appstream/docs/
[2]http://blogs.gnome.org/hughsie/2014/06/11/application-addons-in-gnome-software/

I got question "Is it better to create a metainfo.xml for each plugin, or each _set_ of plugins?" (bug 731632 comment 1) and I think we don't should split plugins here (in upstream), but we should notice maintainers in distros (which supporting AppStream), that would be more better to split packages downstream. That's not hard for they.

I'm working on this bug. So, patch will be availabe in 1-2 hours.
Comment 1 Igor Gnatenko 2014-06-15 10:23:47 UTC
Created attachment 278477 [details] [review]
plugins: add metainfo for all available plugins

Reference: https://bugzilla.gnome.org/show_bug.cgi?id=731676
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Comment 2 Igor Gnatenko 2014-06-15 10:33:00 UTC
Created attachment 278478 [details] [review]
plugins: add metainfo for all available plugins

Reference: https://bugzilla.gnome.org/show_bug.cgi?id=731676
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Comment 3 Igor Gnatenko 2014-06-16 10:11:16 UTC
Created attachment 278523 [details] [review]
plugins: add metainfo for all available plugins

Added bugtracker URL
Comment 4 Felix Riemann 2014-06-27 17:31:50 UTC
Review of attachment 278523 [details] [review]:

::: plugins/exif-display/Makefile.am
@@ +46,3 @@
+
+appstream_DATA = $(appstream_in_files:.xml.in=.xml)
+@INTLTOOL_XML_RULE@

I don't think it's possible to have both INTLTOOL_XML_RULE and XML_NOMERGE_RULE in the same Makefile.
Is it necessary to merge the translations back into the XML?
If yes, we might have to add a copy of the XML_RULE to the file, specialized for the AppStream XML.

::: plugins/exif-display/eog-exif-display.metainfo.xml.in
@@ +7,3 @@
+  <_summary>Displays a few camera setting Exif tags in the sidebar and optionally the statusbar</_summary>
+  <url type="homepage">https://wiki.gnome.org/Apps/EyeOfGnome/Plugins</url>
+  <url type="bugtracker">https://bugzilla.gnome.org/enter_bug.cgi?product=eog&component=plugins</url>

You most likely need to write the '&' as '&amp;' here (and for the other plugins) otherwise it won't be valid XML.
Comment 5 Felix Riemann 2014-08-10 16:36:09 UTC
Pushed the patch with some improvements. Thanks.

commit c98fe6e1530664d1aac894a0161e15e86c7e715a
Author: Felix Riemann <>
Date:   Sun Aug 10 17:53:55 2014 +0200

    Switch to intltool's native GSettings support
    
    Allows coexistence between GSettings and AppData files.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731676

commit f5d9e7bc60bc0b35f645ed79d889a4f9ea39d2f1
Author: Felix Riemann <>
Date:   Sat Aug 9 21:05:54 2014 +0200

    appdata: Escape ampersands in AppData XML
    
    Otherwise the XML is invalid and intltool will complain.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731676

commit 5f20bc3652199e84d4a2b9680fc7d6f92f229196
Author: Igor Gnatenko <>
Date:   Sun Jun 15 12:42:41 2014 +0400

    plugins: add metainfo for all available plugins
    
    Reference: https://bugzilla.gnome.org/show_bug.cgi?id=731676
    Signed-off-by: Igor Gnatenko <>
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.