After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731658 - icon theme: Respect directory types for svg icons
icon theme: Respect directory types for svg icons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-06-14 15:26 UTC by Matthias Clasen
Modified: 2014-06-14 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkIconTheme: Don't treat svg icons specially (4.66 KB, patch)
2014-06-14 15:27 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2014-06-14 15:26:46 UTC 
The current icon loading code special-cases svgs and always loads them at the requested size. This makes it impossible to use svg for things like spinners, which could very well live as svgs in the icon theme, but should not be scaled to giant sizes.
Comment 1 Matthias Clasen 2014-06-14 15:27:22 UTC 
Created attachment 278447 [details] [review]
GtkIconTheme: Don't treat svg icons specially

This changes makes svg icons go through the same scale calculation
code as png icons. As a consequence, an svg that is put into the
32x32 directory will actually be loaded at size 32, even if it
gets requested at a bigger size. This will let us avoid giant
spinners.