After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731639 - The pictures have different proportions, influencing the effect of alignment
The pictures have different proportions, influencing the effect of alignment
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks: 729459
 
 
Reported: 2014-06-14 03:26 UTC by weizhe86
Modified: 2014-11-24 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Alignment (58.86 KB, image/png)
2014-06-14 03:26 UTC, weizhe86 		  Details
widgets: Request same width on artist album covers (1.73 KB, patch)
2014-11-22 09:59 UTC, Arnel Borja 		none Details | Review
widgets: Request same width on artist album covers (1.51 KB, patch)
2014-11-22 11:16 UTC, Arnel Borja 		none Details | Review
widgets: Request same width on artist album covers (1.91 KB, patch)
2014-11-22 11:23 UTC, Arnel Borja 		none Details | Review

Description weizhe86 2014-06-14 03:26:43 UTC 
Created attachment 278432 [details]
Alignment

The pictures have different proportions, influencing the effect of alignment.
Comment 1 Arnel Borja 2014-06-14 15:52:03 UTC 
We probably need to put a GtkSizeGroup here to make all album covers use the same horizontal length, then centering them.
Comment 2 Arnel Borja 2014-11-22 09:59:40 UTC 
Created attachment 291225 [details] [review]
widgets: Request same width on artist album covers

Request same width on albums so that songs in all albums are correctly aligned in Artists view.
Comment 3 Arnel Borja 2014-11-22 11:16:02 UTC 
Created attachment 291226 [details] [review]
widgets: Request same width on artist album covers

Removed PyGObject warning.
Comment 4 Arnel Borja 2014-11-22 11:23:12 UTC 
Created attachment 291227 [details] [review]
widgets: Request same width on artist album covers

Forgot to add a line to commit.
Comment 5 Vadim Rutkovsky 2014-11-24 11:51:09 UTC 
Excellent, pushed https://git.gnome.org/browse/gnome-music/commit/?id=c1a510d to master and https://git.gnome.org/browse/gnome-music/commit/?id=581c2e3 to gnome-3-14