GNOME Bugzilla – Bug 731624
Include Adwaita theming
Last modified: 2014-08-10 15:03:54 UTC
With Adwaita moving into GTK+, the application-specific pieces of the theme have to live with the applications themselves.
Created attachment 278421 [details] [review] Include Adwaita theming
Review of attachment 278421 [details] [review]: as discussed on irc the patch looks good to me. Benjamin does not like this plan very much... on the other hand he does not seem to like any of the plans :P Unless we decide otherwise at the gnome-wide level, feel free to push it
Review of attachment 278421 [details] [review]: should we merge the other css we have into this one?
(In reply to comment #3) > Review of attachment 278421 [details] [review]: > > should we merge the other css we have into this one? No, I think we need the theme-specific part and the generic part separate: over time I would not mind contributions for other themes (in particular gedit.highcontrast.css or gedit.win32.css or similar)
(In reply to comment #2) > Benjamin does not like this plan very much... on the other hand he does not > seem to like any of the plans :P I think this approach is fundamentally wrong because it encourages thinking of Adwaita as an API. The correct fix is to (a) not need custom CSS or (b) put app-specific CSS into the theme. There is no reason why Adwaita cannot have app-specific CSS. Moving files between repositories doesn't change that.
Then let state just as categorically that putting app-specific stuff into the theme is fundamentally wrong. It means that as the number of apps grows the size of the theme tends toward infinity, and every app loads all other the apps' specific theming.
Putting theme-specifc CSS in the app is equally wrong, if not more so. It means that as the number of themes grows the amount of CSS tends towards infinity, and every app needs to maintain every themes' specific theming.
We all know that there are pros and cons to both approaches and that there is no perfect solution. However the "many apps, few themes" scenario seems much more pressing than the "many themes" one. Beside, no one forbids authors of $awesometheme to also include app specific styling like it is done today. I'd say for the time being the patch should go in, though it is pretty bad to have to do this manually instead of just dropping a resource in the binary with proper naming conventions What about the the a11y themes?
See bug 732959 for discusssion of 'load from resource automatically'. For now, I'm going to push this patch
Attachment 278421 [details] pushed as cec4be8 - Include Adwaita theming