After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731619 - Fix Meta.KeyBindingFlags.IS_REVERSED typo
Fix Meta.KeyBindingFlags.IS_REVERSED typo
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-13 14:18 UTC by Christophe Fergeau
Modified: 2014-06-16 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix Meta.KeyBindingFlags.IS_REVERSED typo (1.31 KB, patch)
2014-06-13 14:18 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2014-06-13 14:18:24 UTC 
The code currently tries to use Meta.KeyBindingFlags.REVERSED. Since
this constant is |'ed with Meta.KeyBindingFlags.REVERSES, gjs silently
ignores the unknown flag.
Comment 1 Christophe Fergeau 2014-06-13 14:18:30 UTC 
Created attachment 278414 [details] [review]
Fix Meta.KeyBindingFlags.IS_REVERSED typo
Comment 2 Rui Matos 2014-06-15 18:18:12 UTC 
Review of attachment 278414 [details] [review]:

Right

Actually on the gjs REPL it does warn:

gjs> let a = {}
gjs> 0 | a.a
typein:7: strict warning: reference to undefined property a.a
0

I wonder why the embedded gjs doesn't.
Comment 3 Christophe Fergeau 2014-06-16 10:58:34 UTC 
commit d98c1ba522d34b457fa498d404c3fc3030e3b320
Author: Christophe Fergeau <cfergeau@redhat.com>
Date:   Thu May 29 23:23:32 2014 +0200

    Fix Meta.KeyBindingFlags.IS_REVERSED typo
    
    The code currently tries to use Meta.KeyBindingFlags.REVERSED. Since
    this constant is |'ed with Meta.KeyBindingFlags.REVERSES, gjs silently
    ignores the unknown flag.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731619