After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731533 - wavparse: Infinite loop in wavparse with some files
wavparse: Infinite loop in wavparse with some files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal blocker
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-11 18:14 UTC by Mathieu Duponchelle
Modified: 2014-06-28 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wavparse: Remove break and restore old fallthrough behaviour. (840 bytes, patch)
2014-06-11 18:14 UTC, Mathieu Duponchelle 		rejected Details | Review

Description Mathieu Duponchelle 2014-06-11 18:14:38 UTC 
Reproduction :
wget https://dl.dropboxusercontent.com/u/2804070/STE-002.wav && gst-launch-1.0 playbin uri=file://$PWD/STE-002.wav
The regression was introduced in: 

commit 2e277bb34173b988c10a9f43d39f223a50a9da94
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Mon Dec 30 14:36:45 2013 +0100
wavparse: emit midi-base-note tag from data in 'smpl' chunk
        
Add parsing of the 'smpl' chunk. Right now we only grab the midi-base-note and emit it as a tag.

, and is due to the addition of the break statement at line 1444 in the current code.
The actual solution might be to properly update the offset, but I do not really know that code/format.
Comment 1 Mathieu Duponchelle 2014-06-11 18:14:41 UTC 
Created attachment 278285 [details] [review]
wavparse: Remove break and restore old fallthrough behaviour.
Comment 2 Sebastian Dröge (slomo) 2014-06-23 18:54:47 UTC 
Yes, just the offset needs to be updated :)

commit efaf996b1a6788e3fec31048a348bdaaf2d66c53
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 23 20:53:50 2014 +0200

    wavparse: Update offset after parsing adtl chunk
    
    Otherwise we will parse it over and over again without ever
    getting past it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731533