After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731524 - codecparsers: h264: fix quantization matrix conversion routine names
codecparsers: h264: fix quantization matrix conversion routine names
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-11 13:32 UTC by Gwenole Beauchesne
Modified: 2014-06-12 09:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparsers: h264: fix quantization matrix conversion routine names (5.75 KB, patch)
2014-06-11 13:32 UTC, Gwenole Beauchesne 		committed Details | Review

Description Gwenole Beauchesne 2014-06-11 13:32:42 UTC 
Created attachment 278271 [details] [review]
codecparsers: h264: fix quantization matrix conversion routine names

Fix routine names for zigzag/raster scan order conversion routines for quantization matrices. This ought to use the gst_h264_quant_matrix_*() naming convention instead of gst_h264_video_quant_matrix_*(), which derived from the MPEG-2 function names.

This is a new API (in 1.4) it'd be better to have consistent naming conventions with the rest of the gsth264parser. Thanks.
Comment 1 Tim-Philipp Müller 2014-06-12 09:07:25 UTC 
commit db887f05cafdae8588150daeaa71bf99cfa3c6a2
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Wed Jun 11 15:11:40 2014 +0200

    codecparsers: h264: fix quantization matrix conversion routine names.
    
    Fix routine names for zigzag/raster scan order conversion routines for
    quantization matrices. This ought to use the gst_h264_quant_matrix_*()
    naming convention instead of gst_h264_video_quant_matrix_*(), which
    derived from the MPEG-2 function names.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731524
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>