After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731500 - Conversation view doesn't zoom with Ctrl-Scroll
Conversation view doesn't zoom with Ctrl-Scroll
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
unspecified
Other All
: Normal normal
: 0.8.0
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2014-06-11 05:13 UTC by Robert Schroll
Modified: 2014-06-11 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make zooming conversation view work with smooth scrolling (1.67 KB, patch)
2014-06-11 05:13 UTC, Robert Schroll
committed Details | Review

Description Robert Schroll 2014-06-11 05:13:05 UTC
It's only looking for scroll events with ScrollDirection.UP and DOWN.  
But nowadays, we generally get SMOOTH events.  This patch updates the 
handler to deal with those.
Comment 1 Robert Schroll 2014-06-11 05:13:07 UTC
Created attachment 278246 [details] [review]
Make zooming conversation view work with smooth scrolling

Often, we get smooth scrolling events on WebViews, but the zooming code
looks only for non-smooth scroll events.  This handles both.
Comment 2 Jim Nelson 2014-06-11 19:21:53 UTC
Commit!
Comment 3 Robert Schroll 2014-06-11 20:03:16 UTC
Attachment 278246 [details] pushed as ef984d8 - Make zooming conversation view work with smooth scrolling