Created attachment 280648 [details] [review]
Remove irrelevant TransportActions

Remove "Pause" and "X_DLNA_PS=*" when the uri is an image. Remove
"Seek" when player says it can't seek.

Created attachment 280649 [details] [review]
Fix image playlist "slide show"

The image playlist timer wasn't working: start the timer from both
apply_track() and when playback state changes to PLAYING. This
required some refactoring.

Also, include "Pause" TransportAction for image playlists. Make sure
Pause() method call returns "701 Transition not available" for
individual images, but not for image playlists.

> Remove "Pause" and "X_DLNA_PS=*" when the uri is an image. Remove
> "Seek" when player says it can't seek.

The latter is there for images: I could just check for images specifically but this seems more correct.


The second patch is a bit of a mixed bag: several fixes within image playlist handling that should maybe have been in separate patches... I can try separating them if it's annoying to review.

Have you checked this against the two or three "playlists don't work properly" bugs? Maybe those fixes squashed one of those as well :)

Review of attachment 280648 [details] [review]:

+1, But needs rebasing to master (I've done that locally and will just push that)

Review of attachment 280649 [details] [review]:

Needs rebasing (I've already done that locally)

::: src/librygel-renderer/rygel-player-controller.vala
@@ +348,3 @@
             Idle.add (() => {
                 if (!this.next ()) {
+                    this.playback_state == "STOPPED";

I suppose that should have been this.playback_state = "STOPPED";

@@ -391,1 @@
         }

Shouldn't we still remove the timeout if it's still running or it will be triggered twice?

Attachment 280648 [details] pushed as 7fa02d5 - Remove irrelevant TransportActions