After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731462 - AppData file does not validate
AppData file does not validate
Status: RESOLVED OBSOLETE
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-10 15:17 UTC by Richard Hughes
Modified: 2019-04-03 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Richard Hughes 2014-06-10 15:17:59 UTC
$ appdata-validate gnome-terminal.appdata.xml.in 
gnome-terminal.appdata.xml.in 1 problems detected:
• tag-invalid           : <metadata_license> is not valid

http://people.freedesktop.org/~hughsient/appdata/#metadata_license specifies that only a few licences are valid here -- could you change the value of metadata_license to be something that's suitable for an XML file (and not code)? The validator accepts CC0-1.0, CC-BY-3.0, CC-BY-SA-3.0 and GFDL-1.3

Thanks.

Richard.
Comment 1 Christian Persch 2014-06-10 16:47:36 UTC
AFAICT "GPL-3.0+" is a perfectly valid SPDX licence identifier according to https://spdx.org/licenses/ , so why does the validator think it's invalid?
Comment 2 Richard Hughes 2014-06-10 16:56:03 UTC
http://people.freedesktop.org/~hughsient/appdata/#metadata_license basically explains, but the core issue is when we collect all the information together into one meta-file, we want a licence that's sane, i.e. not a superset of all the possible packages in the repo, but just a superset of a small number. The other reason is we want a *content* license, as you can't really have an XML file under the GPL as it doesn't make much legal sense.
Comment 3 Christian Persch 2014-06-10 17:04:39 UTC
So it's a policy problem, not a wrong SPDX value.

Firstly, GPL is a sane lincence by itself.

Secondly, I disagree on GPLing a XML file; to me it absolutely makes good sense. What exactly is the concern?

Thirdly, I don't see how you have concerns about GPLing an XML file but not GFDLing it?
Comment 4 Christian Persch 2014-06-10 17:15:53 UTC
BTW, http://people.freedesktop.org/~hughsient/appdata/#metadata_license only says the allowable licence IDs "include" the mentioned four, it does *not* say that those are the only ones.
Comment 5 Richard Hughes 2014-06-10 18:36:03 UTC
(In reply to comment #3)
> So it's a policy problem, not a wrong SPDX value.

Correct.

> Firstly, GPL is a sane lincence by itself.

Right, no disagreement there for code -- but for data files that are not code all the legal advice I've been told so far suggested that the GPL is not suited and ambiguous. Content licences like GFDL are a much better fit and legally unambiguous. 

> Secondly, I disagree on GPLing a XML file; to me it absolutely makes good
> sense. What exactly is the concern?

I can't go into details without getting the right permissions, but the basic problem is that the XML file isn't created from code source files -- it's just a data file that's used like an icon.

> Thirdly, I don't see how you have concerns about GPLing an XML file but not
> GFDLing it?

GFDL is designed as a content licence for documentation, GPL was designed as a source licence for code.
Comment 6 Christian Persch 2016-02-21 13:33:40 UTC
Is this still an issue?
Comment 7 Richard Hughes 2016-02-22 19:44:36 UTC
Yes:

• tag-invalid           : <metadata_license> is not valid [GPL-3.0+]

XML needs to be a content license, not a source licence.
Comment 8 Christian Persch 2016-02-22 20:06:49 UTC
Well, I'm not going to licence anything under a non-copyleft licence, so I think this bug is CANTFIX.
Comment 9 Richard Hughes 2016-02-23 09:14:11 UTC
GFDL-1.3 is copyleft (and Debian-free) and suitable for data like this.
Comment 10 Christian Persch 2018-03-03 19:29:06 UTC
I went for GPL3+ and GFDL1.3 dual.
Comment 11 Richard Hughes 2018-03-05 12:00:18 UTC
"GPL-3.0+|GFDL-1.3-only" is not valid SPDX syntax for two reasons:

* You need to use " OR " for the logic
* The SPDX ID is "GFDL-1.3", not "GFDL-1.3-only"

I still don't know how you can license an XML file as GPL-anything, but I suppose if you change it to "GPL-3.0+ OR GFDL-1.3" then I can fix up all the other tools to allow it to validate.
Comment 12 Christian Persch 2018-03-05 12:34:42 UTC
Well, I got that from https://spdx.org/licenses/ which says that "GFDL-1.3-only" is the ID of that licence. That seems to be the official spec for SPDX licence IDs, isn't it?

I can certainly use " OR " instead of "|" (however it's weird that as-spdx.c translates OR to | internally but doesn't accept it as input).