After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731427 - Blinking cursor drawing artifact
Blinking cursor drawing artifact
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.37.x
Other Linux
: Normal minor
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-09 20:27 UTC by Egmont Koblinger
Modified: 2014-06-14 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (382 bytes, patch)
2014-06-10 08:42 UTC, Egmont Koblinger
none Details | Review
fix v2 - save a bit of UI work if we can (592 bytes, patch)
2014-06-10 08:46 UTC, Egmont Koblinger
none Details | Review
fix v3 (593 bytes, patch)
2014-06-12 12:33 UTC, Egmont Koblinger
committed Details | Review

Description Egmont Koblinger 2014-06-09 20:27:55 UTC
With blinking block or i-beam cursor, start the "joe" text editor. The cursor is in col 1, row 2 (below the top bar).

When the cursor is off, press the Up arrow (press it many times if you wish).

Expected: the cursor becomes fully visible (as it is when you type letters).

Actual: only the top part of the cursor is visible.

Notice that joe prints something in the top bar, so in vte's eyes the cursor is actually moved (even though it happens to end up at its previous location, which seems to be necessary to trigger the bug).
Comment 1 Egmont Koblinger 2014-06-09 21:14:58 UTC
The actual bug is that the cursor disappears (and stays so) when a key is pressed but the cursor stays at the same location.  This is also observable when pressing e.g. backspace at the shell prompt (without typing any command).  You don't need the joe editor for this.

Probably invalidating the old cursor, drawing the new one, and setting the cursor to visible happens in the wrong order, or something similar.

I guess if we fix this, the partial cursor with the joe editor will be gone too.
Comment 2 Egmont Koblinger 2014-06-10 08:42:45 UTC
Created attachment 278189 [details] [review]
fix
Comment 3 Egmont Koblinger 2014-06-10 08:46:40 UTC
Created attachment 278190 [details] [review]
fix v2 - save a bit of UI work if we can
Comment 4 Egmont Koblinger 2014-06-12 12:33:43 UTC
Created attachment 278335 [details] [review]
fix v3

Although this patch is functionally equivalent to the previous one, and I don't quite get the intent of the "periodic" parameter, I think FALSE is the semantically correct value.