After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731402 - core: fix metrics of user-added routes
core: fix metrics of user-added routes
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-09 13:39 UTC by Dan Winship
Modified: 2014-06-10 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: fix metrics of user-added routes (6.57 KB, patch)
2014-06-09 13:39 UTC, Dan Winship 		none Details | Review

Description Dan Winship 2014-06-09 13:39:27 UTC 
Fallout from bug 729203, caught by Thomas running the RHEL7 QE tests.
Comment 1 Dan Winship 2014-06-09 13:39:29 UTC 
Created attachment 278135 [details] [review]
core: fix metrics of user-added routes

Adding a route with a metric of 0 to an IP4 or IP6 setting used to
implicitly mean "use the default metric for the device", but this got
broken by 722c9034. Fix that.
Comment 2 Thomas Haller 2014-06-09 14:25:18 UTC 
This looks good to me
Comment 3 Jiri Klimes 2014-06-10 08:13:33 UTC 
The patch looks good to me too.
Comment 4 Dan Winship 2014-06-10 13:17:20 UTC 
pushed to master (cdd0928) and nm-0-9-10 (223a0dd)