After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731392 - Nicer empty state
Nicer empty state
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
available
Depends on:
Blocks:
 
 
Reported: 2014-06-09 08:38 UTC by Allan Day
Modified: 2014-10-14 20:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (24.86 KB, image/png)
2014-06-09 08:39 UTC, Allan Day 		  Details
Better empty state (4.44 KB, patch)
2014-10-13 20:41 UTC, amisha 		needs-work Details | Review
Better empty state (4.44 KB, patch)
2014-10-14 16:44 UTC, amisha 		none Details | Review
Better empty state (4.43 KB, patch)
2014-10-14 19:57 UTC, amisha 		committed Details | Review

Description Allan Day 2014-06-09 08:38:47 UTC 
A message is displayed when music is empty, which explains how to add content. This is good, but the message itself could be improved (a screenshot is attached). A few things:

 * The layout is off - centered text with an icon to the left doesn't work visually.
 * The colour is too dark.
 * The exclamation mark seems unwarranted.
 * The file path won't be recognised by many users, and the language is a bit technical.

A mockup for an improved empty screen:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/music/music-empty.png
Comment 1 Allan Day 2014-06-09 08:39:32 UTC 
Created attachment 278123 [details]
screenshot

I forgot the attachment, of course.
Comment 2 amisha 2014-10-09 17:35:33 UTC 
Screenshot of the work upto now. 
http://ctrlv.in/446441
Comment 3 amisha 2014-10-11 13:45:39 UTC 
http://ctrlv.in/447186
Comment 4 Vadim Rutkovsky 2014-10-11 14:59:44 UTC 
(In reply to comment #3)
> http://ctrlv.in/447186

We shouldn't center the text. I guess left alignment will do better.
Comment 5 amisha 2014-10-13 20:41:58 UTC 
Created attachment 288421 [details] [review]
Better empty state
Comment 6 amisha 2014-10-13 20:43:45 UTC 
Final Screenshot

http://ctrlv.in/448293
Comment 7 Vadim Rutkovsky 2014-10-13 20:47:54 UTC 
Review of attachment 288421 [details] [review]:

::: data/NoMusic.ui
@@ +29,3 @@
+        <property name="margin">10</property>
+        <child>
+          <object class="GtkLabel" id="label1">

This label should be removed afaik

@@ +47,3 @@
+        </child>
+        <child>
+          <object class="GtkLabel" id="label2">

We have used generic names before, but this is a bad idea. Lets rename it to something like NoMusicLabel

@@ +51,3 @@
+            <property name="opacity">0.5</property>
+            <property name="can_focus">False</property>
+            <property name="label">No Music Found</property>

Please set 'translatable="yes"' here
Comment 8 amisha 2014-10-13 20:52:38 UTC 
Vadim if i remove label1 then how will two text (No music found and the other one) have different sizes?
In that case bold and scale attribute will be apply to both the text.
Comment 9 Vadim Rutkovsky 2014-10-14 09:51:32 UTC 
(In reply to comment #8)
> Vadim if i remove label1 then how will two text (No music found and the other
> one) have different sizes?
> In that case bold and scale attribute will be apply to both the text.

Oh, my bad. But in this case resetting a text in .py file is pointless - we can set it straight in .ui file
Comment 10 amisha 2014-10-14 16:44:20 UTC 
Created attachment 288537 [details] [review]
Better empty state
Comment 11 amisha 2014-10-14 19:57:46 UTC 
Created attachment 288550 [details] [review]
Better empty state
Comment 12 Vadim Rutkovsky 2014-10-14 20:12:57 UTC 
Review of attachment 288550 [details] [review]:

Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=968281d to master