GNOME Bugzilla – Bug 731369
libostree: Make several APIs explicitly private
Last modified: 2014-06-09 18:06:19 UTC
Right now we export all symbols starting with ostree_, so fix several internal APIs that should be private to be prefixed with '_'.
Created attachment 278096 [details] [review] libostree: Make OstreeLibarchiveInputStream explicitly private We weren't installing the headers, but at the moment all symbols starting with ostree_ were being exported. Fix that by prefixing non-static symbols with '_'.
Created attachment 278097 [details] [review] libostree: Make OstreeTlsCertInteraction explicitly private Similar to previous commit, this should be private.
Created attachment 278098 [details] [review] libostree: Make OstreeFetcher explicitly private Per previous commit. We're not attempting to export an HTTP to clients, the high level API is ostree_repo_pull().
Review of attachment 278096 [details] [review]: ::: src/libostree/ostree-libarchive-input-stream.h @@ -18,3 @@ * Boston, MA 02111-1307, USA. - * - * Author: Alexander Larsson <alexl@redhat.com> Bad Colin.
Review of attachment 278097 [details] [review]: OK.
(In reply to comment #4) > Review of attachment 278096 [details] [review]: > > ::: src/libostree/ostree-libarchive-input-stream.h > @@ -18,3 @@ > * Boston, MA 02111-1307, USA. > - * > - * Author: Alexander Larsson <alexl@redhat.com> > > Bad Colin. Yeah, I'll separate that out as a separate commit.
Review of attachment 278098 [details] [review]: You aren't reindenting anything. You decide if that's OK.
Created attachment 278157 [details] [review] libostree: Remove leftover Author: tag I copied the structure of the header file from GIO, but there's really nothing left from there, and I'm trying to get away from the Author: tag as git is a much better record of who actually authored code.
Review of attachment 278157 [details] [review]: Nevermind, this is a separate bug.
(In reply to comment #7) > Review of attachment 278098 [details] [review]: > > You aren't reindenting anything. You decide if that's OK. Yeah...for stuff like this it bloats the diffs too much for review I feel - I tend to go by and fix up the indentation later as I'm editing the code.
Attachment 278096 [details] pushed as 9f73449 - libostree: Make OstreeLibarchiveInputStream explicitly private Attachment 278097 [details] pushed as 4ce93db - libostree: Make OstreeTlsCertInteraction explicitly private Attachment 278098 [details] pushed as 24c64d6 - libostree: Make OstreeFetcher explicitly private