After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731325 - Fails to build with srcdir != builddir
Fails to build with srcdir != builddir
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-06 09:45 UTC by Vadim Rutkovsky
Modified: 2014-06-12 07:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (2.40 KB, patch)
2014-06-06 09:45 UTC, Vadim Rutkovsky
committed Details | Review

Description Vadim Rutkovsky 2014-06-06 09:45:33 UTC
Created attachment 278001 [details] [review]
Patch

Folks fails to build for out-of-tree build. Attached patch fixed this for me.

I've built it with the following options: "--disable-fatal-warnings --enable-vala --disable-inspect-tool --disable-libsocialweb-backend --disable-tests --disable-zeitgeist --enable-telepathy-backend --enable-eds-backend", so different options list might require additional patches
Comment 1 Simon McVittie 2014-06-06 11:34:04 UTC
I'm no expert, but this patch looks like a good start, at least...

Which version of Vala, and which version of Automake, does this work with? It would probably be good to keep track of a known-good configuration.
Comment 2 Vadim Rutkovsky 2014-06-06 11:53:02 UTC
(In reply to comment #1)
> Which version of Vala, and which version of Automake, does this work with?
I tried this with vala-0.20 and automake-1.13.4, if I'm not mistaken this should work latest vala also
Comment 3 Philip Withnall 2014-06-12 07:18:28 UTC
Thanks for the patch. It works with Vala 0.24.0.16-c045 for me, so I've pushed with a few whitespace fixes.